274086 - nsStringAPI.h has unused variables in with non-debug builds

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Crispin Flowerday (not receiving bug mail)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a6) Gecko/20041204 Galeon/1.3.18.99
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a6) Gecko/20041204 Galeon/1.3.18.99

In galeon, we #include <nsEmbedString.h>, which of course brings in
nsStringAPI.h,  we compile with -Werror to catch compile warnings, and
nsStringAPI.h breaks the build as follows:

In file included from /opt/mozilla/include/mozilla-1.8a6/nsEmbedString.h:43,
                 from GulString.h:31,
                 from nsAboutRedirector.cpp:46:
/opt/mozilla/include/mozilla-1.8a6/nsStringAPI.h: In member function `
   nsDependentSubstring_external::nsDependentSubstring_external(const
   nsAString&, unsigned int, unsigned int)':
/opt/mozilla/include/mozilla-1.8a6/nsStringAPI.h:1425: warning: unused variable
   `PRUint32 len'
/opt/mozilla/include/mozilla-1.8a6/nsStringAPI.h: In member function `
   nsDependentCSubstring_external::nsDependentCSubstring_external(const
   nsACString&, unsigned int, unsigned int)':
/opt/mozilla/include/mozilla-1.8a6/nsStringAPI.h:1481: warning: unused variable
   `PRUint32 len'

This is with non-debug builds of mozilla.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Crispin Flowerday (not receiving bug mail)]

Attachment: Simple fix

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in xpcom/string/public/nsStringAPI.h;
/cvsroot/mozilla/xpcom/string/public/nsStringAPI.h,v  <--  nsStringAPI.h
new revision: 1.13; previous revision: 1.12
done