If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

pref-appearance.xul accesskeys need to move to .dtd

VERIFIED FIXED

Status

SeaMonkey
Preferences
P3
normal
VERIFIED FIXED
18 years ago
9 years ago

People

(Reporter: Fergus Sullivan, Assigned: Ben Goodger (use ben at mozilla dot org for email))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
xpfe/components/prefwindow/resources/content/pref-appearance.xul 

This file contains 6 accesskey definitions which should be moved to the 
corresponding .dtd file.

The lines in question are as follows:
<html:label for="generalStartupBrowser" accesskey="n" tabindex="0">
<html:label for="generalStartupMail" accesskey="m" tabindex="0">
<html:label for="generalStartupEditor" accesskey="c" tabindex="0">
<html:label for="browserChromeToolbarStyle2" accesskey="p" tabindex="0">
<html:label for="browserChromeToolbarStyle0" accesskey="o" tabindex="0">
<html:label for="browserChromeToolbarStyle1" accesskey="t" tabindex="0">
I'll take these
Assignee: matt → ben
fix checked in. 
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 3

18 years ago
Bulk move of all Pref UI component bugs to new Preferences component.  Pref UI 
component will be deleted.
Component: Pref UI → Preferences
if verification is as easy as making sure those lines appear in the dtd file,
cool, then 'verifyme' can be removed from keywords. otherwise, if there's
additional functionality that needs testing here, i'd like some other [qa or
otherwise] help on verifying this.
Keywords: verifyme
(Reporter)

Comment 5

18 years ago
Verification should proceed as follows:
1) Have the English UI strings been moved from the .xul file to the .dtd file?
2) Does the UI in this file actually display correctly at runtime?
3) Does the entity name in the .xul file match the entity name in the .dtd file?  
If not, the string concerned will not display correctly (and probably will not 
display at all).
thanks, fergus!

spoke with paulmac, who sez that from the perspective of this bug, steps (1) and
(3) are relevant. if (2) doesn't work, we'll file a separate bug. :-)
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

Updated

9 years ago
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.