274117 - Change first-review flag to review in Product Update

Status: RESOLVED INVALID

(bugzilla.mozilla.org :: Administration, task)

Description

[Wolf [:wolf]]

In the Update product, the only review flag is "first-review" which should be
just "review". (IIRC, Only Calendar does first and second review.) Thanks.

Comment 1

[timeless]

first: you don't. toolkit has the same flag. 
second, here's a list of flags, pick the one that sounds the best based on their descriptions.
as to renaming this one, i'd need to talk to mostafah at least.

review
Camino reviews.
first-review
The patch has passed its first review.
review
analysis and testing of the patch to ensure correctness and applicability
^ this is bugzilla and using it sends mail to the bugzilla reviewers' list.
review
Seamonkey: The patch has passed review by a module owner or peer.
review
Firefox and Thunderbird: this patch has passed review by a module owner or peer.
second-review
The patch has passed its second review.
superreview
The patch has passed review by a super-reviewer.

Comment 2

[Wolf [:wolf]]

humm, ok. :-) Don't rename anything that touches another product. (my
understanding was flags were unique to each product. oops.)

first-review on its own seems wrong to me (as I'd expect second-review to be
there too.)

I'm used to the Seamonkey/Firefox/Thunderbird concept of 'review'. Which seems
to apply here the best.

Comment 3

[Asa Dotzler [:asa]]

The choice then, is to use one of the existing review flags (from seamonkey or
elsewhere) or create a new review flag specific to Update.

Comment 4

[Wolf [:wolf]]

One of the existing ones is fine. :-) Update's not special. 

Comment 5

[Asa Dotzler [:asa]]

The downside of using an existing one is that if it needs to change, you change
with it or lose your flag date by migrating to a new one later. Does this
matter? Ways it might change are to start auto-cc'ing people, become restricted
in who can request and who can set, become or stop being multiplicable, etc. 

Comment 6

[Reed Loden [:reed]]

marcia is now the default assignee for Bugzilla: Keywords & Components.

Comment 7

[Marcia Knous [:marcia]]

No activity on this in some time. Is this still needed?

Comment 8

[Wolf [:wolf]]

Probably not. (Though I'm no longer part of the dev team for that product.) They've been doing development for the better part of a year without this change. So I'm doubting its needed anymore, It was a minor thing to start with anyway. :-)

Comment 9

[Wolf [:wolf]]

Doesn't appear to still be needed, no comments in some time, so I don't think this is particularly needed anymore.

Resolving.