274136 - add method to set xpcshell's exit code

Status: RESOLVED INACTIVE

(Core :: XPConnect, defect)

Description

[Mike Shaver (:shaver emeritus)]

This will make it easier to write test scripts that run in an automated way. 
Patch in a trice.

Comment 1

[Mike Shaver (:shaver emeritus)]

Attachment: setExitCode(n) sets gExitCode to n (if omitted, 0)

What could be simpler?

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 168458 [details] [diff] [review]
setExitCode(n) sets gExitCode to n (if omitted, 0)

r=dmose

Comment 3

[David Bradley]

I thought Quit took a parameter that was to be the return value of XPCShell?

Comment 4

[Bernd]

this breaks the windows build, see creature (and my depend build ;-))

Comment 5

[Bernd]

I backed out, I tried to contact shaver via IRC, bugzilla, and email. This patch
burns the firefox tb for 2h with no sign of a fix.

Comment 6

[Mike Shaver (:shaver emeritus)]

Pretending for a moment that the patch didn't break the tree, yes, I suppose
Quit does.  We were looking for a way to set the exit code as well as return it
from an inner test function, so that tests run interactively wouldn't exit the
shell, but when run non-interactively would set the exit code appropriately.

Clearly, I was going too fast here on several counts.  Apologies!

Comment 7

[Mike Shaver (:shaver emeritus)]

Mass abdication.

Comment 8

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.