The prefs mousewheel.horizscroll.* are already available to control horizontal scrolling with secondary wheels or mice where one can switch the behaviour of the wheel (like Logitech mouse drivers for single wheel mice). Since at least currently the hidden prefs have bad defaults (see bug 231718) for the horizontal movements it is somewhat necessary to implement these as GUI options to get users to find this possibility. The first draft of a patch for this issue unfortunately made it into bug 143038 first where it was misplaced. I will shortly add the newest patch that takes into account the review comments from the first version.
Created attachment 168477 [details] [diff] [review] 2nd patch This patch gets rid of unnecessary ids of the <vbox>es, rectifies the use of accesskeys (they are all different now and not "h"), and enlarges the section in the help file a bit, and tries to keep the format as in the rest of the file.
Ian, does the help text in this patch sound OK to you now?
Comment on attachment 168477 [details] [diff] [review] 2nd patch >+<!ENTITY scrollPgLtPgRt.accesskey "l"> Try to see if you can improve on "l" as an access key, see http://www.mozilla.org/access/keyboard/accesskey.html
Thanks. And right, "l" does not make a good access key. AFAIU from the document you pointed out, OK does not need an accesskey so the best for this case would probably be "o", so that we get "Scr_o_ll a page left or a page right".
Comment on attachment 168477 [details] [diff] [review] 2nd patch sr=jag. Sorry it took so long! Don't forget to change that 'l' to 'o'.
Created attachment 173355 [details] [diff] [review] Final patch, corrected accesskey (checked in) Final patch, apart from version numbers this diff's only change is scrollPgLtPgRt.accesskey "o" instead of "l". Thanks for the reviews, which I carry over to this patch. Can someone please check it in?
Comment on attachment 173355 [details] [diff] [review] Final patch, corrected accesskey (checked in) Checking in xpfe/components/prefwindow/resources/content/pref-mousewheel.xul; /cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-mousewheel.x ul,v <-- pref-mousewheel.xul new revision: 1.42; previous revision: 1.41 done Checking in xpfe/components/prefwindow/resources/locale/en-US/pref-mousewheel.dtd; /cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-mousewh eel.dtd,v <-- pref-mousewheel.dtd new revision: 1.11; previous revision: 1.10 done Checking in extensions/help/resources/locale/en-US/cs_nav_prefs_advanced.xhtml; /cvsroot/mozilla/extensions/help/resources/locale/en-US/cs_nav_prefs_advanced.x html,v <-- cs_nav_prefs_advanced.xhtml new revision: 1.35; previous revision: 1.34 done
Sorry, just want to assign to me to let me find the bugs I worked on...