Last Comment Bug 274179 - Add horizontal options to mouse wheel prefs panel
: Add horizontal options to mouse wheel prefs panel
Status: VERIFIED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Preferences (show other bugs)
: Trunk
: All All
: -- enhancement with 1 vote (vote)
: ---
Assigned To: Peter Weilbacher
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-12-11 04:54 PST by Peter Weilbacher
Modified: 2006-01-15 10:05 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
2nd patch (23.85 KB, patch)
2004-12-11 05:01 PST, Peter Weilbacher
neil: review+
jag-mozilla: superreview+
Details | Diff | Splinter Review
Final patch, corrected accesskey (checked in) (23.44 KB, patch)
2005-02-04 04:15 PST, Peter Weilbacher
mozilla: review+
mozilla: superreview+
Details | Diff | Splinter Review

Description Peter Weilbacher 2004-12-11 04:54:40 PST
The prefs mousewheel.horizscroll.* are already available to control horizontal
scrolling with secondary wheels or mice where one can switch the behaviour of
the wheel (like Logitech mouse drivers for single wheel mice).
Since at least currently the hidden prefs have bad defaults (see bug 231718) for
the horizontal movements it is somewhat necessary to implement these as GUI
options to get users to find this possibility.

The first draft of a patch for this issue unfortunately made it into bug 143038
first where it was misplaced. I will shortly add the newest patch that takes
into account the review comments from the first version.
Comment 1 Peter Weilbacher 2004-12-11 05:01:18 PST
Created attachment 168477 [details] [diff] [review]
2nd patch

This patch gets rid of unnecessary ids of the <vbox>es, rectifies the use of
accesskeys (they are all different now and not "h"), and enlarges the section
in the help file a bit, and tries to keep the format as in the rest of the
file.
Comment 2 Peter Weilbacher 2004-12-11 05:03:24 PST
Ian, does the help text in this patch sound OK to you now?
Comment 3 neil@parkwaycc.co.uk 2005-01-16 07:20:30 PST
Comment on attachment 168477 [details] [diff] [review]
2nd patch

>+<!ENTITY scrollPgLtPgRt.accesskey     "l">
Try to see if you can improve on "l" as an access key, see
http://www.mozilla.org/access/keyboard/accesskey.html
Comment 4 Peter Weilbacher 2005-01-17 07:05:15 PST
Thanks. And right, "l" does not make a good access key. AFAIU from the document
you pointed out, OK does not need an accesskey so the best for this case would
probably be "o", so that we get "Scr_o_ll a page left or a page right".
Comment 5 jag (Peter Annema) 2005-02-04 00:53:31 PST
Comment on attachment 168477 [details] [diff] [review]
2nd patch

sr=jag. Sorry it took so long! Don't forget to change that 'l' to 'o'.
Comment 6 Peter Weilbacher 2005-02-04 04:15:31 PST
Created attachment 173355 [details] [diff] [review]
Final patch, corrected accesskey (checked in)

Final patch, apart from version numbers this diff's only change is
scrollPgLtPgRt.accesskey "o" instead of "l". Thanks for the reviews, which I
carry over to this patch.

Can someone please check it in?
Comment 7 Ian Neal 2005-02-04 05:20:20 PST
Comment on attachment 173355 [details] [diff] [review]
Final patch, corrected accesskey (checked in)

Checking in xpfe/components/prefwindow/resources/content/pref-mousewheel.xul;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-mousewheel.x
ul,v  <--  pref-mousewheel.xul
new revision: 1.42; previous revision: 1.41
done
Checking in
xpfe/components/prefwindow/resources/locale/en-US/pref-mousewheel.dtd;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-mousewh
eel.dtd,v  <--	pref-mousewheel.dtd
new revision: 1.11; previous revision: 1.10
done
Checking in extensions/help/resources/locale/en-US/cs_nav_prefs_advanced.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/cs_nav_prefs_advanced.x
html,v	<--  cs_nav_prefs_advanced.xhtml
new revision: 1.35; previous revision: 1.34
done
Comment 8 Peter Weilbacher 2006-01-15 10:04:16 PST
Sorry, just want to assign to me to let me find the bugs I worked on...

Note You need to log in before you can comment on or make changes to this bug.