The default bug view has changed. See this FAQ.

Add horizontal options to mouse wheel prefs panel

VERIFIED FIXED

Status

SeaMonkey
Preferences
--
enhancement
VERIFIED FIXED
13 years ago
11 years ago

People

(Reporter: Peter Weilbacher, Assigned: Peter Weilbacher)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

23.44 KB, patch
Peter Weilbacher
: review+
Peter Weilbacher
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

13 years ago
The prefs mousewheel.horizscroll.* are already available to control horizontal
scrolling with secondary wheels or mice where one can switch the behaviour of
the wheel (like Logitech mouse drivers for single wheel mice).
Since at least currently the hidden prefs have bad defaults (see bug 231718) for
the horizontal movements it is somewhat necessary to implement these as GUI
options to get users to find this possibility.

The first draft of a patch for this issue unfortunately made it into bug 143038
first where it was misplaced. I will shortly add the newest patch that takes
into account the review comments from the first version.
(Assignee)

Comment 1

13 years ago
Created attachment 168477 [details] [diff] [review]
2nd patch

This patch gets rid of unnecessary ids of the <vbox>es, rectifies the use of
accesskeys (they are all different now and not "h"), and enlarges the section
in the help file a bit, and tries to keep the format as in the rest of the
file.
(Assignee)

Comment 2

13 years ago
Ian, does the help text in this patch sound OK to you now?
(Assignee)

Updated

13 years ago
Attachment #168477 - Flags: superreview?(jag)
Attachment #168477 - Flags: review?(neil.parkwaycc.co.uk)

Comment 3

12 years ago
Comment on attachment 168477 [details] [diff] [review]
2nd patch

>+<!ENTITY scrollPgLtPgRt.accesskey     "l">
Try to see if you can improve on "l" as an access key, see
http://www.mozilla.org/access/keyboard/accesskey.html
Attachment #168477 - Flags: review?(neil.parkwaycc.co.uk) → review+
(Assignee)

Comment 4

12 years ago
Thanks. And right, "l" does not make a good access key. AFAIU from the document
you pointed out, OK does not need an accesskey so the best for this case would
probably be "o", so that we get "Scr_o_ll a page left or a page right".

Comment 5

12 years ago
Comment on attachment 168477 [details] [diff] [review]
2nd patch

sr=jag. Sorry it took so long! Don't forget to change that 'l' to 'o'.
Attachment #168477 - Flags: superreview?(jag) → superreview+
(Assignee)

Comment 6

12 years ago
Created attachment 173355 [details] [diff] [review]
Final patch, corrected accesskey (checked in)

Final patch, apart from version numbers this diff's only change is
scrollPgLtPgRt.accesskey "o" instead of "l". Thanks for the reviews, which I
carry over to this patch.

Can someone please check it in?
Attachment #168477 - Attachment is obsolete: true
Attachment #173355 - Flags: superreview+
Attachment #173355 - Flags: review+

Comment 7

12 years ago
Comment on attachment 173355 [details] [diff] [review]
Final patch, corrected accesskey (checked in)

Checking in xpfe/components/prefwindow/resources/content/pref-mousewheel.xul;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-mousewheel.x
ul,v  <--  pref-mousewheel.xul
new revision: 1.42; previous revision: 1.41
done
Checking in
xpfe/components/prefwindow/resources/locale/en-US/pref-mousewheel.dtd;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-mousewh
eel.dtd,v  <--	pref-mousewheel.dtd
new revision: 1.11; previous revision: 1.10
done
Checking in extensions/help/resources/locale/en-US/cs_nav_prefs_advanced.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/cs_nav_prefs_advanced.x
html,v	<--  cs_nav_prefs_advanced.xhtml
new revision: 1.35; previous revision: 1.34
done
Attachment #173355 - Attachment description: Final patch, corrected accesskey → Final patch, corrected accesskey (checked in)
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

11 years ago
Sorry, just want to assign to me to let me find the bugs I worked on...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

11 years ago
Assignee: prefs → mozilla
Status: REOPENED → NEW
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.