274231 - Error handling for invalid version numbers (vid) passed to moreinfo.php

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[John Mellor (Jomel)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

If an incorrect vid is passed to moreinfo.php, it goes wrong and returns a
useless mostly-empty page that is very confusing for people who just followed a
link to the page.

It should instead check that the version exists, and if it doesn't then display
a helpful message (see below).

Reproducible: Always
Steps to Reproduce:
Go to https://update.mozilla.org/extensions/moreinfo.php?id=176&vid=335

Or, more generally:
1. Go to the More Info page for any extension
2. Replace the vid in the address with an invalid one, or add an invalid one if
there isn't one
Actual Results:  
Page is useless.
The page is also visibly broken, notably:
 * PHP error: Warning: Invalid argument supplied for foreach() in
/opt/update/extensions/moreinfo.php on line 139
 * "[blank] by [blank]"
 * "Released on December 31, 1969"
 * Invalid download link
 * Even worse, the link to All Releases is broken!

Expected Results:  
Output: "Sorry, the version you wanted is no longer listed here. Perhaps you
wanted the <a href="[same url without the vid]">latest version</a>." and maybe
have a delayed redirect to that page; or if no versions of the extension are
currently listed on update.mozilla.org then output "Sorry, this extension is not
currently listed here."

(and of course have no PHP errors or invalid stuff)

Incidentally for the same reason, moreinfo.php should show a warning when
displaying an old version of an extension, but that's bug 256486.

Note that most of the links google harvests include vids, and these often go out
of date yet stay at the top of search results, which would be less of a problem
if both this and bug 256486 were fixed.

Comment 1

[Wolf [:wolf]]

Strangely enough, that URL works fine if you try update-beta. :-)


http://update-beta.mozilla.org/extensions/moreinfo.php?id=16&vid=618

Comment 2

[alanjstr]

If it works in beta, can we mark this as fixed?

Comment 3

[Wolf [:wolf]]

I'll mark it as fixed when I feel it is. Thanks.

Comment 4

[Wolf [:wolf]]

This should be fixed in update-beta.

http://update-beta.mozilla.org