274306 - Replace [buttondown] and [buttonover] rules for some buttons of _ThunderBird_ to work using :active and :hover rules

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Serge Gautherie (:sgautherie)]

Bug 257280 is for the themes; this one for ThunderBird,
per bug 257280 comment 2
{{
... other bugs would have to be opened for composer/ etc.
}}

Comment 1

[Serge Gautherie (:sgautherie)]

Scott:

I'm in trouble with </mail/components/compose/skin/mac/messengercompose.css>:
it seems that some of its end-of-lines won't allow my Windows' CVS to create a
suitable diff file :-(
Can you check and repair it ?
Thanks.

Comment 2

[Serge Gautherie (:sgautherie)]

Neil:
Can you help with the CVS file issue ?

Comment 3

[Serge Gautherie (:sgautherie)]

Anyone:
Any hint on how you or I could fix the file !? Please...

Comment 4

[[e-mail]]

Sorry, I forgot to mention that I fixed the line endings a fortnight ago.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) MAS-port

"Same" as bug 257280 patch Cv1.

I don't use TB: Could you test/review/check in this patch ? Thanks.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 172392 [details] [diff] [review]
(Cv1) MAS-port

No review from <[e-mail]> since "2005-01-25" :-(

{{
I don't use TB: Could you test/review/check in this patch ? Thanks.
}}

Comment 7

[Scott MacGregor]

FYI, patches with comments like "i've never built or tested this patch please
test and review" no matter how trivial are always going to be at the bottom of
our review priority list and will experience long delays.

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #7)
> FYI, patches with comments like "i've never built or tested this patch please
> test and review" no matter how trivial are always going to be at the bottom of
> our review priority list and will experience long delays.

I can understand that;
and I would be happy to work with any FF/TB user who would volunteer to test my
simple patches ... in order to reduce this "wait forever" kind of situation.
My few attempts to find someone to do the "non-MAS" check-in part have failed.
If you could point me to someone for both these tasks which i cannot do, it
could help us all !?

Comment 9

[Brian Ryner (not reading)]

Comment on attachment 172392 [details] [diff] [review]
(Cv1) MAS-port

Please do not request reviews for untested patches unless the reviewer has
agreed to test your patch.

Comment 10

[Scott MacGregor]

Attachment: (Cv1b) updated fix [Checked in: Comment 11]

Ihad to update this patch since the theme files have been re-organzied.

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 186404 [details] [diff] [review]
(Cv1b) updated fix
[Checked in: Comment 11]


Check in: { 2005-06-15 15:35	scott%scott-macgregor.org }

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 186404 [details] [diff] [review]
(Cv1b) updated fix
[Checked in: Comment 11]

'approval1.1a2=?':
Trivial CSS code cleanup, no risk.
Already checked in :-|

Comment 13

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1b) "nits" [Checkin: See comment 14]

1 missed cleanup and 2 regressed nits between Cv1 and Cv1b.

Comment 14

[Scott MacGregor]

Comment on attachment 186420 [details] [diff] [review]
(Cv1b) "nits"
[Checkin: See comment 14]

i checked this in

Comment 15

[Scott MacGregor]

Comment on attachment 186404 [details] [diff] [review]
(Cv1b) updated fix
[Checked in: Comment 11]

clearing flags for a patch I already landed.

Comment 16

[Serge Gautherie (:sgautherie)]

Comment on attachment 186420 [details] [diff] [review]
(Cv1b) "nits"
[Checkin: See comment 14]

'approval1.1a2=?':
Trivial CSS code cleanup, no risk.
Already checked in :-|

Comment 17

[Scott MacGregor]

Comment on attachment 186420 [details] [diff] [review]
(Cv1b) "nits"
[Checkin: See comment 14]

Please stop asking me to approve fixes I've already checked in!