274336 - calEvent.icalComponent produces inconsistent results

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

In the testcase i create two events, and then try to get a ics string from it.
The results between the two events are not consitent.
Part of the output:

DTSTART
 ;VALUE=DATE
 :00000100
DTSTART
 :00000100T000000

Those are from the two events.

Now, you can argue that there should not be a dtstart at all, but I've also seen
it happen for CREATED. One event has a date, the other a datetime. It is quite
random. (maybe time-related?)

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: Testcase

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: anohter testcase

actually, the first testcase gives different created values.
this second, simpler, testcase only does it for dtstart.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Just to illustrate the randomness: using the first testcase, i added a dump() to
calItemBase.js, and suddenly both events had a datetime, instead of one date and
one datetime.

Comment 4

[Mike Shaver (:shaver emeritus)]

Interesting, I'll step through this on the plane.

Comment 5

[Mike Shaver (:shaver emeritus)]

Is this with our libical, or your newer version, BTW?

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

I used the version of libical that's in the tree. Didn't with try the new
version yet.

Comment 7

[Mike Shaver (:shaver emeritus)]

Indeed, we were not always initializing mIsDate.  Vlad reviewed the obvious
one-liner, we should be good now.  Reopen if you can still reproduce this; I was
never able to with my build, so I can't really tell.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

works for me now too.