274337 - Clicking on the button makes it shrink in size (float:left and next to select drop down)

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect)

Description

[Martijn Wargers (dead)]

Clicking on one of the buttons on that size makes them shrink.
I'll attach a minimal testcase.

It seems like a regression:
Not happening in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624
Happening in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030718

Comment 1

[Martijn Wargers (dead)]

Attachment: Testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

I don't see it shrink, but I do see a change in size.  Seems to regress between
2003-06-14-05 and 2003-06-15-05 nightly builds.

I don't really see anything in that range that would cause this, though.  :(

Comment 3

[Mats Palmgren (inactive)]

Attachment: Testcase #2

Comment 4

[Mats Palmgren (inactive)]

Tracing frame->GetStyleFont()->mFont.name and .size in nsHTMLReflowState::Init :
font=Arial,serif:240 in normal state and
font=Arial,serif:200 when the button is pressed (for Testcase #2, Line 1.)

Looks like a style system problem...

Comment 5

[Mats Palmgren (inactive)]

Attachment: fix?

This fixes it, I'm not sure exactly why 'medium' is needed there though...
Maybe this has something to do with it:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/style/nsRuleNode.cpp&rev=1.156&root=/cvsroot&mark=642-663#635

Comment 6

[Mats Palmgren (inactive)]

Bug 98765 seems the most likely culprit in the interval Boris mentioned...

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That looks like an invalid 'font' declaration.

Comment 8

[Mats Palmgren (inactive)]

Comment on attachment 186712 [details] [diff] [review]
fix?

Yeah, my mistake... so we should fix this then:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/style/forms.css&rev=
3.101&root=/cvsroot&mark=106#100

Comment 9

[Mats Palmgren (inactive)]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/style/forms.css&rev=3.101&root=/cvsroot&mark=106#100

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

-moz-fixed is a generic font-family, -moz-button is a system font.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Perhaps what you want is:

font: -moz-button;
font-size: medium;

?

Comment 12

[Mathieu Parent]

see also bug 199755

Comment 13

[Martijn Wargers (dead)]

This is now worksforme, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007120505 Minefield/3.0b2pre