Closed Bug 274352 Opened 20 years ago Closed 19 years ago

Customize Toolbar dialog needs titlebar and border

Categories

(Calendar :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: seanh, Assigned: mostafah)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041209 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041209 Firefox/1.0+

View-->Customize Toolbar... The dialog that appears with all the possible
buttons, does not have a titlebar. This makes it impossible to move the dialog,
and without a border it cannot be resized, unlike the customize toolbar dialog
in ff or tb.

Reproducible: Always
Steps to Reproduce:
1.View-->Customize Toolbar
2.Notice an inability to move or resize the dialog

Actual Results:  
No titlebar

Expected Results:  
Shown titlebar to move dialog and border to resize.
We're using the same code to open the Customize Toolbar window as FF, so I'm not
sure what the issue is.

Us:
http://lxr.mozilla.org/seamonkey/source/calendar/resources/content/calendar.js#1631

FF:
http://lxr.mozilla.org/seamonkey/source/browser/base/content/browser.js#2583

Which version of Sunbird are you seeing the issue in?
If it's not 0.2RC1, could you please try to replicate the issue using that version?

The an image of the problem on my computer - Sunbird v0.2rc1
Despite lilmatt's comment, I can confirm this in Sunbird 0.2 (20050203).  The
customize toolbar window has no window borders or titlebar.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Found what I think the issue is.

In customizeToolbar.js on line 27 there is this:

document.documentElement.setAttribute("hidechrome", "true");

On its removal the titlebar reappears.

Seems very simple, but I don't know how to write a patch.
Nevermind, fixed in latest nightlies.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Sean,
    Impressive work.  Writing a patch isn't too tough, especially if you use
Gerv's patchmaker from http://www.gerv.net/software/patch-maker/

However, 1.) customizeToolbar.js is not a part of Sunbird, but rather of the
generic Toolkit that Firefox, Thunderbird, etc, all use.  It works fine there
with the line you mentioned, so you can't just pull it. :-(
2.) [Removed comment about checking latest nightlies].

Tracking down a possible solution to this problem, though, was good work.  If
you get Gerv's patchmaker set up and would like some other bugs of similar
difficulty to work on, feel free to email me and I'll be happy to provide some
suggestions.
*** Bug 286290 has been marked as a duplicate of this bug. ***
The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!
QA Contact: gurganbl → general
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: