274392 - Search name not preserved when clicking Edit from Saves Searches in prefs

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[David Balažic]

When editing a saved search ( from Prefs / Saved Searches .. )
The submit button is labeled "Search".
Shouldn't that be "Save" ?

Aha, I see it perfomr the search, not saves it.

But in the results page, at least the Remember as field should be prefilled with
the search name, don't you think ?

Comment 1

[Dave Miller [:justdave]]

Yep, you are correct.  It is indeed intended to keep the query name so it shows
up in the box already when you run it.

Comment 2

[:glob ✱]

Attachment: remember saved query name v1

Comment 3

[Rob Siklos [:robzilla]]

the above patch might work for 2.18, but 2.19 already has most of this
functionality as per bug 98751.  However, that bug was only targeted for 2.20. 
Personally, I think that it would be easy enough and worthwhile to backport it
to 2.18 (which is what I did on my implementation).

To fix it in 2.19, all you have to do is change one line in
template/en/default/account/prefs/saved-searches.html.tmpl:

<a href="query.cgi?[% q.query FILTER html %]">Edit</a>

becomes

<a href="query.cgi?[% q.query FILTER html %]&known_name=[% q.name FILTER
url_quote %]">Edit</a>

Comment 4

[Rob Siklos [:robzilla]]

Comment on attachment 168623 [details] [diff] [review]
remember saved query name v1

bug is reported against 2.19, but patch is not on trunk (which contains most of
the fix already)

Comment 5

[Rob Siklos [:robzilla]]

Attachment: rsiklos_v1

patch corresponding to comment #3

Comment 6

[:glob ✱]

rsiklos: note the target milestone for this bug is 2.18

Comment 7

[Marc Schumann [:Wurblzap]]

So...
If most of it happens in bug 98751 for the trunk, but is now considered
blocking2.18, too, doesn't a backport perhaps make sense then? (Is attachment
168623 [details] [diff] [review] perhaps a backport?)
Would attachment 168669 [details] [diff] [review] apply to both trunk and branch in that case?

Comment 8

[:glob ✱]

attachment 168623 [details] [diff] [review] isn't a backport of bug 98751, as i wasn't aware of that bug
until rob's comments.

attachment 168669 [details] [diff] [review] won't fix the problem without the backport, so i'll backport
bug 98751 which will resolve the issue in the same manner across the branch and
trunk.

Comment 9

[:glob ✱]

Attachment: backport of bug 98751

Comment 10

[:glob ✱]

Comment on attachment 168669 [details] [diff] [review]
rsiklos_v1

clearing r? on obsolete patch

Comment 11

[Rob Siklos [:robzilla]]

glob: I can't see the original problem being fixed without adding attachment
168669 [details] [diff] [review] to your patch (for the 2.18 branch).

For the trunk, that attachment should be fine on it's own.  Have a look at the
description - the problem is that the box isn't prepopulated when clicking the
"Edit" link from the Saved Searches panel in the preferences screen.

Comment 12

[:glob ✱]

Comment on attachment 169043 [details] [diff] [review]
backport of bug 98751

oops

Comment 13

[:glob ✱]

Attachment: backport of bug 98751 + rsiklos_v1

right you are rob, sorry about that.

Comment 14

[Rob Siklos [:robzilla]]

Comment on attachment 168669 [details] [diff] [review]
rsiklos_v1

we need a patch for the branch and for the trunk.
Attachment 169046 [details] [diff] is for the 2.18 branch; this is the one for the trunk.  

Removing obsolete flag and requesting review.

Comment 15

[:glob ✱]

Comment on attachment 168669 [details] [diff] [review]
rsiklos_v1

r=glob

Comment 16

[Jacob Steenhagen]

Comment on attachment 169046 [details] [diff] [review]
backport of bug 98751 + rsiklos_v1

Looks good to me :)

Comment 17

[Jacob Steenhagen]

Attachment 168669 [details] [diff] is for the tip while attachment 169046 [details] [diff] [review] is for the 2.18 branch
(which it's blocking :).

Comment 18

[Vlad Dascalu]

Checking in saved-searches.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/saved-searches.html.tmpl,v
 <--  saved-searches.html.tmpl
new revision: 1.5; previous revision: 1.4


Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.255.2.5; previous revision: 1.255.2.4
done
Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.126.2.2; previous revision: 1.126.2.1
done
Checking in template/en/default/account/prefs/saved-searches.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/saved-searches.html.tmpl,v
 <--  saved-searches.html.tmpl
new revision: 1.2.2.2; previous revision: 1.2.2.1
done
Checking in template/en/default/list/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v 
<--  list.html.tmpl
new revision: 1.25.2.1; previous revision: 1.25
done
Checking in template/en/default/search/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v 
<--  knob.html.tmpl
new revision: 1.15.2.1; previous revision: 1.15
done
Checking in template/en/default/search/search-specific.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-specific.html.tmpl,v
 <--  search-specific.html.tmpl
new revision: 1.7.2.2; previous revision: 1.7.2.1
done