274400 - Safari doesn't show lock icons

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[timeless]

Safari 1.2.4 (v125.11) doesn't show lock icons.
justdave claims it works in mac ie 5.2

Comment 1

[timeless]

regression, requesting blocking release and such...
because security bugs are no longer distinguishable on buglists in Safari

Comment 2

[Dave Miller [:justdave]]

Are the locks actually in 2.18 or is that a 2.19 thing?

Comment 3

[Frédéric Buclin]

NS 4.7 had the same problem. The problem is that old browsers use the html file
as the absolute path to start with instead of the CSS file.

This may work, but I haven't Safari. Please try:

background-image: url("images/padlock.png");
@media all {
background-image: url("../../images/padlock.png");
}

I think Safari won't understand @media all and will use the first path while
modern browser will use the second path.

Comment 4

[Dave Miller [:justdave]]

(In reply to comment #3)

> I think Safari won't understand @media all and will use the first path while
> modern browser will use the second path.

Safari is a modern browser. :)

And the path isn't the issue, I tried straight out changing it to
"images/padlock.png" on http://webtools.mozilla.org/bztest/ and now it doesn't
show up in any of IE, Safari, or Firefox.

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> And the path isn't the issue, I tried straight out changing it to
> "images/padlock.png" on http://webtools.mozilla.org/bztest/ and now it doesn't
> show up in any of IE, Safari, or Firefox.
> 

IE and Firefox need "../../images/padlock.png", because the path must be
relative to the CSS file. About Safari, I don't know. I only tell you what I did
with NS 4.7.

My syntax in comment 3 was incorrect as background-image: url() must be in
tr.bz_secure td.first-child {...} but the idea was correct.

I cannot tell you more if I don't know what Safari understands about CSS. :(

Comment 6

[Nick Barnes]

Attachment: v1 for 2.18 branch

It's apparently the multi-line classes, like this:

<tr class="bz_foo
	   bz_bar
	   bz_baz">

Stops the CSS from working in Safari.  Whether it's valid HTML/CSS or not I
neither know no care.  It's trivial to tell the template toolkit to drop the
newlines at the ends of these lines.  Here's a patch, tested on 2.18 tip
against Safari and Firefox.

Comment 7

[Nick Barnes]

Attachment: v1 for trunk

Very similar patch for trunk, also tested.

Comment 8

[Vlad Dascalu]

Comment on attachment 168625 [details] [diff] [review]
v1 for 2.18 branch

As far as I know you can have tags on multiple lines but quoted values on
multiple lines might have problems.

I'm still unhappy that Safari doesn't handle this :-). As far as I know this is
the only portion in the code where we have a class attribute on multiple lines
(or any other quoted value on multiple lines).

Comment 9

[Vlad Dascalu]

Checking in template/en/default/list/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl,v 
<--  table.html.tmpl
new revision: 1.21; previous revision: 1.20
done

Checking in template/en/default/list/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl,v 
<--  table.html.tmpl
new revision: 1.16.2.4; previous revision: 1.16.2.3
done

Comment 10

[Shane H. W. Travis]

*** Bug 275416 has been marked as a duplicate of this bug. ***