274408 - iCalendar export shows summaries only after comma (must be escaped)

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

[unsure whether this is the right component...]

I tried to export a buglist as iCalendar file; when importing into evolution
1.4, for summaries that contained a comma (','), only the part after it was shown.

Per http://www.kanzaki.com/docs/ical/summary.html the value type of SUMMARY is TEXT.

From http://www.kanzaki.com/docs/ical/text.html#def it seems that commas must be
escaped, but they aren't in the ics file.

Comment 1

[Dave Miller [:justdave]]

Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.

Comment 2

[Colin Leroy]

Attachment: Escape commas in ics filter

Here's a patch that fixes it.

Comment 3

[Stefan Sitter [:ssitter]]

Is there an ETA when this problem will be fixed? At the moment Bugzilla creates invalid iCalendar files. In iCalendar files, commas in all text fields must be escaped as \, (otherwise it is interpreted as multiple value separator). As the result calendar clients (e.g. Sunbird, Lightning) can't display the events/tasks properly. (And results in Bugs blaming Sunbird, e.g. Bug 351723 ;-)

Comment 4

[Frédéric Buclin]

Comment on attachment 214532 [details] [diff] [review]
Escape commas in ics filter

>                              $var =~ s/([;\\\"])/\\$1/g;
>+                             $var =~ s/,/\\,/g;

All you have to do is to add "," to the existing list of characters to escape, on the first line above.

Comment 5

[Frédéric Buclin]

This is a trivial change and indeed fixes the problem (I tested importing the list with Lightning on Thunderbird). I will approve it for 2.22.2 and 3.0RC1 if anyone wants to update the patch.

Comment 6

[Frédéric Buclin]

Attachment: patch, v1.1

No need to wait any longer for a one-liner. Updating the patch myself, r=LpSolit. Lightning 0.5 is not affected anymore as it now reads commas correctly, but I could still reproduce the bug with Lightning 0.3.1.

Comment 7

[Frédéric Buclin]

Let's take it for 2.22.3 too.

Comment 8

[Frédéric Buclin]

tip:

Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v  <--  Template.pm
new revision: 1.73; previous revision: 1.72
done

3.0:

Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v  <--  Template.pm
new revision: 1.68.2.2; previous revision: 1.68.2.1
done

2.22.2:

Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v  <--  Template.pm
new revision: 1.41.2.4; previous revision: 1.41.2.3
done