274456 - Problems with "mark as new" checkbox

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Bill Mason]

When attempting to move an unconfirmed bug using the "Reassign bug to owner and
QA contact of selected component" radio button, clicking that button also
checked off the "and confirm bug (change status to NEW)" of the *above* radio
button ("Reassign bug to").

Comment 1

[Bill Mason]

Wrong component.  Taking a stab at a better one.

Comment 2

[Frédéric Buclin]

(In reply to comment #0)
> When attempting to move an unconfirmed bug using the "Reassign bug to owner and
> QA contact of selected component" radio button, clicking that button also
> checked off the "and confirm bug (change status to NEW)" of the *above* radio
> button ("Reassign bug to").

Yeah... I have seen this for a long time already, but I don't think the status
of the bug gets modified, isn't it? Hummm... I cannot find a dupe, strange! :)

I might consider this in the near future if nobody takes it before. ;)

Comment 3

[Bill Mason]

(In reply to comment #2)
> Yeah... I have seen this for a long time already, but I don't think the status
> of the bug gets modified, isn't it?

I don't know if it does or not.  I didn't want the bug I was working on marked
new, so I unchecked it.

Comment 4

[Frédéric Buclin]

(In reply to comment #3)
> I don't know if it does or not.  I didn't want the bug I was working on marked
> new, so I unchecked it.

This is a good reason to get it fixed very quickly. This can be very
annoying/confusing, even if the bug remains unconfirmed. I think this affects
2.18 also, so requesting them as blockers for both versions.

Comment 5

[Frédéric Buclin]

Grrr!! I could not understand why this problem did not appear on my installation
and I realized after 15 minutes this was because I already fixed this bug a few
weeks ago, but I never opened a bug for that because I considered it as minor(*)! :(

So the fix is trivial and will come in 10 minutes!


(*) To be honest, this fix was included in my patch for bug 266579. ;)

Comment 6

[Frédéric Buclin]

This is not a regression as this already existed in 2.18!

This is due to a missing </label> tag, which means that 2.16 is not affected as
that version does not use labels.

Comment 7

[Frédéric Buclin]

Attachment: add the missing </label>

Trivial patch.

Comment 8

[Vlad Dascalu]

Comment on attachment 168660 [details] [diff] [review]
add the missing </label>

Since this is for 2.18 and modifies the templates, I guess it will tickle
justdave in a wrong way. Oh well.

Comment 9

[Dave Miller [:justdave]]

and where's the patch for the trunk, or does this one apply?

This is broken on the tip still (since it got reported against b.m.o)

Comment 10

[Frédéric Buclin]

(In reply to comment #9)
> and where's the patch for the trunk, or does this one apply?
> 
> This is broken on the tip still (since it got reported against b.m.o)

This patch is for both the trunk and 2.18!

Comment 11

[Frédéric Buclin]

Requesting again for approval as this patch works for both versions. FYI, I
wrote it based on the trunk.

Comment 12

[Dave Miller [:justdave]]

(In reply to comment #10)
> This patch is for both the trunk and 2.18!

Ah, but you didn't say that (and then vladd said it was for 2.18, so I got
confused ;)

check in at will! :)

Comment 13

[Vlad Dascalu]

I said the bug is for 2.18, not the patch :), but heh, I guess it doesn't matter
anymore :)

Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--
 knob.html.tmpl
new revision: 1.9; previous revision: 1.8
done

Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--
 knob.html.tmpl
new revision: 1.6.2.2; previous revision: 1.6.2.1
done

Comment 14

[Frédéric Buclin]

*** Bug 275062 has been marked as a duplicate of this bug. ***