274550 - javascript protocol inside href tag prevents saving extensions to disk

Status: RESOLVED WORKSFORME

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[nrlz]

The current U.M.O. extension website uses javascript links to initiate an
installation. i.e.,

====
<a href="javascript: void(InstallTrigger.
install({'MyExtension1.0':'extension.xpi'}) )">
(Install Now)</a>
====

But this prevents people from saving the extension directly (through alt+click
or "Save Link As...") if they wanted to archive copies of the extension to their
hard drive.

It would be nice to move the javascript to an "onclick" event handler instead of
having it in the href. That way people can still right-click and do a "Save Link
As..." and normal clicking would still run the javascript. It would also allow
people to install extensions even if they have their javascript off, in which it
defaults to the mime-type handler.

====
<a href="extension.xpi"
onclick="InstallTrigger.install({'MyExtension1.0':'extension.xpi'}); return
false;">(Install Now)</a>
====

Comment 1

[Wolf [:wolf]]

This is already fixed in update-beta. (https://update-beta.mozilla.org) The
javascript use currently was a quick and dirty method implemented for short-term
use.