Closed
Bug 274648
Opened 21 years ago
Closed 21 years ago
crash using repeat element on Windows
Categories
(Core Graveyard :: XForms, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: aaronr, Assigned: aaronr)
Details
(Keywords: crash)
Attachments
(2 files)
1012 bytes,
application/xhtml+xml
|
Details | |
1.20 KB,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
Mozilla can crash or hang on Windows if you use a testcase with a repeat element
in it. There is an assertion:
###!!! ASSERTION: You can't dereference a NULL nsCOMPtr with operator->().:
'mRawPtr != 0', file ../../dist/include/xpcom\nsCOMPtr.h, line 849
Error loading URL file:///X:/myprogs/xml/xforms/easyrepeat.xhtml : 804b0002
I'll attach testcase and patch.
This case shows the problem.
The problem is with line 426 in nsXFormsRepeatElement.cpp:
rv = child->GetNextSibling(getter_AddRefs(child));
getter_AddRefs monkeys with the comptr before it is passed in, so child will
all of the sudden become nsnull before it is offset to find GetNextSibling
function.
proposed fix. Testcase still doesn't show all of the items in the repeat, but
I don't think that has anything to do with the patch.
Attachment #168732 -
Flags: superreview?(bryner)
Attachment #168732 -
Flags: review?(allan)
Comment 3•21 years ago
|
||
Comment on attachment 168732 [details] [diff] [review]
proposed fix
r+sr=darin (thinko!)
Attachment #168732 -
Flags: superreview?(bryner)
Attachment #168732 -
Flags: superreview+
Attachment #168732 -
Flags: review?(allan)
Attachment #168732 -
Flags: review+
Comment 4•21 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 5•21 years ago
|
||
(In reply to comment #2)
> Created an attachment (id=168732) [edit]
> proposed fix
>
> proposed fix. Testcase still doesn't show all of the items in the repeat, but
> I don't think that has anything to do with the patch.
Nope, that's a known bug (bug 266685). You need to style group and repeat so
they are styled properly.
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•