Closed Bug 274679 Opened 20 years ago Closed 20 years ago

nsHashPropertyBag asserts if enumerated before a property is added

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: shaver, Assigned: shaver)

Details

Attachments

(1 file)

ensure initialization before enumerating
700 bytes, patch
vlad
: review+
darin.moz
: superreview+
Details | Diff | Splinter Review 
We just assume that the mPropertyHash is initialized before enumerating it, but
that just isn't always the case.  Patch coming up to initialize, rather than
detect the case and create an empty enumerator.  I don't care much about the
performance of that case, and this is less code.

        Attachment #168744 -
        Flags: superreview?(darin)

        Attachment #168744 -
        Flags: review?(vladimir)

    
    

    
  
Comment on attachment 168744 [details] [diff] [review]
ensure initialization before enumerating

r=vladimir@pobox.com

        Attachment #168744 -
        Flags: review?(vladimir) → review+

    
  

        Attachment #168744 -
        Flags: superreview?(darin) → superreview+

    
    

    
  
Thanks for reviews, fixed on trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: