274853 - find highlight css markup shows up in View Selection Source

Status: VERIFIED DUPLICATE of bug 236465

(Toolkit :: View Source, defect)

Description

[Tae Kim]

When you do View Selection Source on areas that are highlighted by the find
toolbar, you can see the code in the form of:
<span id="__firefox-findbar-search-id" style="background-color: yellow;">text</span>

1. Find and highlight some text on a page.
2. Select the yellow highlighted text.
3. Right-clicked on the selected text and select "View Selection Source".

Result: You can see the css markup used to make the text yellow.
Expected Results: You only see the source for the actual page.

Comment 1

[Phil Ringnalda (:philor)]

Hmm. That would not be my expected result, since view selection source is
supposed to show the DOM that was used to render that particular selection, and
Find's highlighting is inserted in the DOM. Not putting it in the DOM might be
my expected result, but given that it does, with view selection source I'm
likely to be wondering why something got broken by highlighting, and hoping to
see why based on where the span was inserted.

Comment 2

[Tae Kim]

If that's the case, then it should also show up in the regular View Page Source.
But it doesn't and that's inconsistent. Personally, I think view source should
only display the source of the page and not some extraneous info inserted by the
browser. Plus, I think it should be one way or the other, not both.

Comment 3

[Phil Ringnalda (:philor)]

In that case, you are headed toward either a dup of bug 164906 (Seamonkey, but
although they are forked, they are in sync especially as to the basic function,
and the fact that if your selection was entirely generated by script, there
would be no way to show the selection source), or at least of bug 236465 (name
it something that makes it obvious what it is). But if you want view selection
source to just be view source + autofind, you would find plenty of people to
object to the loss of their "how it got that way" view, even if it were possible.

Comment 4

[Nickolay_Ponomarev]

*** This bug has been marked as a duplicate of 236465 ***