hook up mailnews prefs for the permissions extension

RESOLVED FIXED

Status

SeaMonkey
MailNews: Message Display
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Michiel van Leeuwen (email: mvl+moz@), Assigned: Michiel van Leeuwen (email: mvl+moz@))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

after fixing bug 240070, there is now a way to block all content in mailnews.
But the pref used there to block content in mailnews doesn't have UI yet.
I suggest to just make it use the current pref, so that we don't have to update
the UI and don't have to write pref migration code.
(Assignee)

Comment 1

14 years ago
Created attachment 168854 [details] [diff] [review]
patch v1

This patch looks simple, but it does mean that all remote content will be
blocked when the pref is set, like images, iframes and stylesheets.
Attachment #168854 - Flags: review?(mscott)

Updated

14 years ago
Attachment #168854 - Flags: review?(mscott) → review+
(Assignee)

Comment 2

14 years ago
Comment on attachment 168854 [details] [diff] [review]
patch v1

see comment 1 for what this patch actually does
Attachment #168854 - Flags: superreview?(bienvenu)

Comment 3

14 years ago
http://lxr.mozilla.org/mozilla/source/configure.in#3504

do we need to add this to the list of extensions for thunderbird? what about
other apps in that list, e.g. camino?

if we do, the code will need some massaging since nsContentBlocker is built
always, and we don't want that.

also, for the record, there exists profile migration code for firefox - see e.g.
http://lxr.mozilla.org/mozilla/source/browser/base/content/browser.js#5071

Comment 4

14 years ago
Comment on attachment 168854 [details] [diff] [review]
patch v1

I'm going to pass the buck to mscott on this one.
Attachment #168854 - Flags: superreview?(bienvenu) → superreview?(mscott)
(Assignee)

Comment 5

14 years ago
(In reply to comment #3)
> http://lxr.mozilla.org/mozilla/source/configure.in#3504
> 
> do we need to add this to the list of extensions for thunderbird? what about
> other apps in that list, e.g. camino?

thunderbird has its own contentpolicy, so doesn't need this. Camino might need
it. I don't know if that currentlt allows blocking of images.

> if we do, the code will need some massaging since nsContentBlocker is built
> always, and we don't want that.

Only browsers need this extension, not thunderbird. No need for the massaging.

> also, for the record, there exists profile migration code for firefox - see e.g.
> http://lxr.mozilla.org/mozilla/source/browser/base/content/browser.js#5071

I already covered migration of firefox prefs. somewhere.
And this patch doesn't need any migration, because it makes new code read the
old, existing pref.

Comment 6

13 years ago
camino doesn't use image blocking as of 0.8+. so i guess all my questions are
answered :)

mscott, any chance of getting to this before beta? it would be a nice little
codesize win to get rid of old code, if we can land this.
(Assignee)

Comment 7

13 years ago
Comment on attachment 168854 [details] [diff] [review]
patch v1

Darin, can you look at this? It only affects seamonkey mailnews, not
thunderbird.
With this patch, the old img mananger can be removed. codesize win :)
Attachment #168854 - Flags: superreview?(mscott) → superreview?(darin)

Updated

13 years ago
Attachment #168854 - Flags: superreview?(darin) → superreview+
(Assignee)

Comment 8

13 years ago
patch checked in
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

13 years ago
Blocks: 287672

Comment 9

13 years ago
Hi
I just found this bug which still doesn't seem to be fixed...?
I'm using Mozilla 1.7.8 (20050511) and i have remote images disabled in the prefs.
I received a html mail with a stylesheet and first it did was ask me if the
certificate was correct.. that's when i saw that something isn't working as it's
supposed to...?
The Content type is text/html and the mail begins with:
<html>
<head>
<title>citydisc.ch - Infos</title>
<link href="https://212.59.151.34/css/dm/win.css" rel=stylesheet type=text/css>
</head>

So it appears as if that stylesheet got loaded...?!
(Assignee)

Comment 10

13 years ago
it's fixed on trunk, not on the 1.8 branch.
You need to log in before you can comment on or make changes to this bug.