274915 - RSS icon not shown for feeds in frames

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Paolo Bonzini]

The live bookmarks feature may show the RSS icon even for feeds listed in
frames. In the linked page, the "main" (central) frame has an RSS feed but the
live bookmark icon does not show up.

In this particular case, the frameset is not only being generated dynamically,
but will be dropped mid-term (a few months).  For these reasons, changing the
particular frameset is not an option.  Anyway, I believe that this is best
solved within the browser.

Thank you,

Paolo Bonzini

Comment 1

[Oliver Klee]

Changing summary from "Live bookmarks" to "RSS icon shown even for feeds in frames".

Paolo, in the future, please try to enter the bug report summary as specific as
possible so that it's clear what the problem is. Thanks!

Comment 2

[Phil Ringnalda (:philor)]

Readjusting the summary to reverse the reversed meaning: we do *not* show the
icon for feeds <link>ed from the contents of a frame, but we should.

Comment 3

[Phil Ringnalda (:philor)]

Attachment: testcase frame contents

Contents for forthcoming frameset testcase.

Comment 4

[Phil Ringnalda (:philor)]

Attachment: testcase frameset

Frameset, wherein we fail to spot the feed inside a frame.

Comment 5

[Phil Ringnalda (:philor)]

Interesting question without an obvious answer: suppose that the frameset has a
<link>, the frame content has a <link>, and then the user follows an <a> link
that loads a new document in the frame, which has a third <link>. On the initial
load, we should be showing link 1 and link 2, but after the subframe navigation
should we be showing link 1 and link 3, or links 1, 2, and 3?

Comment 6

[Phil Ringnalda (:philor)]

Fixed by, er, something, probably the _getContentShell stuff in bug 303848
(which answers my question with "showing links 1, 2, and 3").

Comment 7

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change