274938 - History sidebar broken

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Tracy Walker [:tracy]]

seen on windows Firefox trunk build 2004-12-16-07-trunk

this regressed since build 2004-12-15-08-trunk

-Browse a few pages
-ctrl+H (open the history sidebar

tested results:
displayed in the history sidebar;
<treeitem uri="rdf.*"
ref:type="rdfhttp://www.w3.org/1999/02/22-rdf-syntax-ns#type">
----------^

expected results:
History folders/items displayed

Comment 1

[Bill Mason]

*** Bug 274937 has been marked as a duplicate of this bug. ***

Comment 2

[Bill Mason]

The duped bug speculates that yesterday's fix for bug 192139 could have caused this.

Comment 3

[Peter Van der Beken [:peterv]]

Bug 192139 might have exposed this, but afaict the problem is simply that the
rdf prefix is not bound to a namespace. Adding
xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" to the page element
should solve it.

Comment 4

[Peter Van der Beken [:peterv]]

... to the page element in
http://lxr.mozilla.org/seamonkey/source/browser/components/history/content/history-panel.xul
...

Comment 5

[Steffen Wilberg]

Attachment: patch

as suggested by peterv. This does indeed fix the bug. We're using that in other
places as well, like
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/bookmarks/content/bookmarksPanel.xul&mark=30

Comment 6

[Steffen Wilberg]

-> peterv.

Comment 7

[Steffen Wilberg]

Checking in mozilla/browser/components/history/content/history-panel.xul;
/cvsroot/mozilla/browser/components/history/content/history-panel.xul,v  <-- 
history-panel.xul
new revision: 1.27; previous revision: 1.26
done

Comment 8

[Tracy Walker [:tracy]]

Verified with Windows Fx trunk build 12-17