274958 - don't return NS_ERROR_FAILURE when INITIAL-IZATION fails

Status: RESOLVED INVALID

(Core :: Layout: Text and Fonts, defect)

Description

[timeless]

the proper thing to do is change from NS_GENERIC_FACTORY_CONSTRUCTOR to 
NS_GENERIC_FACTORY_CONSTRUCTOR_INIT

Comment 1

[Bastiaan Jacques]

Attachment: fix

as described in comment #0.

Comment 2

[Bastiaan Jacques]

Attachment: better fix

NS_GENERIC_FACTORY_CONSTRUCTOR_INIT needs a second argument..

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 189295 [details] [diff] [review]
better fix

   mCtlObj = do_CreateInstance(kLECID, &rv);
-  if (NS_FAILED(rv)) {
+  NS_ENSURE_TRUE(rv, rv);

erm, this will return basically always... and it will show a warning in the
common case that rv is NS_OK.

+  virtual nsresult Init();

why virtual?

Comment 4

[Bastiaan Jacques]

Attachment: even better fix

Thanks biesi!

Comment 5

[Bastiaan Jacques]

Attachment: the right patch..

..this time.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Simon, this patch has been waiting for review for a few years...

Comment 7

[Simon Montagu :smontagu]

Comment on attachment 189333 [details] [diff] [review]
the right patch..

This is obsolete code AFAIK

Comment 8

[Justin Wood (:Callek)]

RESO/INVALID per c#7 (Bastiaan, thanks for your efforts anyway)