274965 - running a search saved by editing an existing search retains wrong search name

Status: RESOLVED WORKSFORME

(Bugzilla :: Query/Bug List, defect)

Description

[Rob Siklos [:robzilla]]

To replicate:

1) Create a search and save it as ABC
2) Run the ABC search
3) click on "Edit Search"
4) on the search page, just run the search again without changing anything
5) save the search as XYZ
6) run the XYZ search

In the "Remeber search as" box, you'll see ABC instead of XYZ.

I think the solution to this is to change list.html.tmpl near the bottom from:

   <input type="text" name="newqueryname" size="20"
          value="[% defaultsavename FILTER html %]"> 
to
   <input type="text" name="newqueryname" size="20"
          value="[% searchname OR defaultsavename FILTER html %]"> 

The above solution is for backward compatibility - the real solution is to not
save the "query_based_on" parameter from the URL when saving a query to the
database.  However, I don't know the sexy way to do this, so no patch yet.

See bug 98751 for original enhancement.

Comment 1

[Rob Siklos [:robzilla]]

Requesting blocking2.20 - 

If bug 98751 gets backported to 2.18 as per bug 274392, then this issue should
also be blocking 2.18

Comment 2

[Rob Siklos [:robzilla]]

nevermind - this bug actually doesn't happen on b.m.o for some reason.  sorry
for the bother

Comment 3

[Frédéric Buclin]

removing the blocking2.20? flag as the reporter closed the bug.