274966 - Need new attachment interface

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Stuart Parmenter]

We need a new attachment interface that doesn't depend on mailnews.

Comment 1

[Stuart Parmenter]

Attachment: calIAttachment and friends

Here is a super simple interface/implementation for this.  The idea here is to
present ICS data blobs as data: urls in the interface and regular urls as
themselves.  We'll add support for more mac stuff as we need to.

Comment 2

[Stuart Parmenter]

Attachment: Full attachment support

So this patch should get all the attachment stuff working, but my nsArray
creation doesn't seem to work in calItemBase.. Can one of you take a look?

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #2)
> Created an attachment (id=168919) [edit]
> Full attachment support
> 
> So this patch should get all the attachment stuff working, but my nsArray
> creation doesn't seem to work in calItemBase.. Can one of you take a look?

Looks ok to me; is it ending up as null?  Or something else?  Is the getter for
.attachments correctly hooked up?  I'm still not happy with using a nsIArray
here, because we have no way of making it immutable when we need to do so...

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Perhaps there needs to be a "MakeImmutable" method on nsI(Mutable?)Array that
effects the behavior of both QI and all relevant operations in nsMutableArray
that attempt to make changes?

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #4)
> Perhaps there needs to be a "MakeImmutable" method on nsI(Mutable?)Array that
> effects the behavior of both QI and all relevant operations in nsMutableArray
> that attempt to make changes?

Maybe, though nsIArray might be frozen -- however, we can always add a
nsIMutable mixin (attribute boolean isMutable; void makeImmutable();).  I think
nsIMutable would be the best way to go, and we can make our interfaces use it as
well.

Comment 6

[Stuart Parmenter]

This stuff is mostly in the tree now.  Marking fixed