275019 - query defaults are selected in query.cgi when only boolean chart params are passed

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[timeless]

expected results: because params are provided to query.cgi, only the params to
query.cgi are used to fill the form

actual results: resolution=---|duplicate is also selected

Comment 1

[Gervase Markham [:gerv]]

timeless: are you sure this is a regression?

Gerv

Comment 2

[Dave Miller [:justdave]]

This is not a regression, I can reproduce this on 2.16.7

It appears to only happen with the boolean chart fields.  If the only params you
pass in are boolean chart related, it fills the default query AND your params.

Comment 3

[Jacob Steenhagen]

Attachment: Patch v1

This patch should work for the tip, 2.18 and 2.16.

Comment 4

[Max Kanat-Alexander]

Arr. OK, the summary was really confusing, changing slightly. (It took me a few
minutes to understand what the bug was about, when I wanted to review it.)

Comment 5

[Max Kanat-Alexander]

Comment on attachment 169280 [details] [diff] [review]
Patch v1

>+        # If the name begins with field, type, or value, then it is part of
>+        # the boolean charts. Because these are built different than the rest
>+        # of the form, we don't need to save a default value. We do, however,
>+        # need to indicate that we found something so the default query isn't
>+        # added in if all we have are boolean chart items.
>+        if ($name =~ m/^(?:field|type|value)/) {
>+            $foundone = 1;
>+        }

  This looks great. I tested it on the tip, 2.18-branch, and 2.16-branch, and
it works fine.

>@@ -395,6 +403,9 @@
>     $vars->{'category'} = Bugzilla::Chart::getVisibleSeries();
> }
> 
>+$vars->{'known_name'} = $cgi->param('known_name');
>+
>+
> # Add in the defaults.
> $vars->{'default'} = \%default;

  This looks like it's part of a separate patch, as there is no known_name var
needed in the 2.18 templates, and this patch is already checked-in on the tip.
Make SURE to remove this section before checkin.

Comment 6

[Jacob Steenhagen]

(In reply to comment #5)
> >@@ -395,6 +403,9 @@
> >     $vars->{'category'} = Bugzilla::Chart::getVisibleSeries();
> > }
> > 
> >+$vars->{'known_name'} = $cgi->param('known_name');
> >+
> >+
> > # Add in the defaults.
> > $vars->{'default'} = \%default;
> 
>   This looks like it's part of a separate patch, as there is no known_name var
> needed in the 2.18 templates, and this patch is already checked-in on the tip.
> Make SURE to remove this section before checkin.

Yep, it is. I think it's from a patch that already landed... but I don't
remember for certain :)... definately need to make sure it's not in the patch
that gets checked in.

Comment 7

[Frédéric Buclin]

I think a new patch with the unnecessary lines removed would be a good idea...

Comment 8

[Dave Miller [:justdave]]

(In reply to comment #7)
> I think a new patch with the unnecessary lines removed would be a good idea...

I agree.  I want one here before I approve it for checkin.  Especially since
this is something people who pick and choose patches to apply to old installs
might be likely to grab.

Comment 9

[Max Kanat-Alexander]

Attachment: Fixed Patch

OK, here's the same patch with that section removed.

Comment 10

[Jacob Steenhagen]

Checked into tip, 2.18, and 2.16.

Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.134; previous revision: 1.133
done


Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.126.2.3; previous revision: 1.126.2.2
done


Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.98.2.3; previous revision: 1.98.2.2
done

Comment 11

[timeless]

*** Bug 203951 has been marked as a duplicate of this bug. ***