275030 - Approvals not working

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[alanjstr]

I tried to approve Linky.  I only checked the Installed box, since that is all I
tested (you don't want me to lie, do you?), the radio button for Approve, and
then submitted.  At the top of the page it says

Processing changes to approval queue, please wait...

but Linky is still there.

Comment 1

[Wolf [:wolf]]

This is not a bug.

Comment 2

[alanjstr]

I selected Approve and it didn't.  

I don't even know what the "clean profile" checkbox is supposed to mean.  If it
means that I used a clean profile to test, then that doesn't make sense. 
Extensions should be able to live with each other.  

If it is required that I must populate every single field before I can approve
soemthing, there should be a javascript edit that won't let me set the radio button.

Comment 3

[Michael Hendy (Hendikins)]

@Alan: This is why the title attribute has been used. Read it.

Comment 4

[alanjstr]

Title attribute on what?  I moved my mouse around and nothing jumped out at me.  

What, other than TBE, qualifies as making a profile not clean?  What does TBE
have to do with something like Gmail notifier?

@H
Wolf told me to approve Linky.  I'm not going to lie and say that I tested every
single thing.

Comment 5

[Michael Hendy (Hendikins)]

@Alan: Then complete all required actions for approval :-)

I've also prodded Wolf about making the tooltips more obvious/useful. I am sure
I can safely assume that will be fixed.

Comment 6

[alanjstr]

there is no feedback as to why it didnt succeed.  it shouldn't let me even
select Approve until all required actions have been performed.

Comment 7

[Wolf [:wolf]]

It didn't succeed because you didn't complete your work.
There is no JS magic on this form and no need for it.

Comment 8

[Wolf [:wolf]]

Attachment: Add error when queue silent skips, make tooltips discoverable

Comment 9

[Wolf [:wolf]]

Attachment: Attempt 2

Comment 10

[Wolf [:wolf]]

Patch checked in.

This patch makes an error appear when the queue silent skips an item because of
incomplete info, and improves the discoverbility of the tooltips.