275059 - move datepicker, timepicker width to css (for skin/theme/customization)

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: 

datepicker and timepicker width is hardcoded in the xul.
Move it to css so it can be adjusted by a skin or theme.

Reproducible: Always

Comment 1

[gekacheka]

Attachment: patch datepicker, timepicker to move width to css, add images to modern only

(patch -l -p 2 -i file.patch)

datepicker.xbl:  remove style (width)
timepicker.xbl:  remove style (width)
datepicker.css:  add style width, remove datepicker button (no longer used)
timepicker.css:  add style width, remove timepicker button (no longer used)

modern datepicker.css, timepicker.css only: 
add calendar and clock as images (plain, disabled) inside field
make wider for space.

Comment 2

[gekacheka]

Attachment: Date and time pickers with icons (Task dialog, modern skin, disabled & enabled)

Example of what pickers look like if skin/theme widens them and inserts icons.

Comment 3

[Matthew (lilmatt) Willis]

I think gekacheka's idea to move the style from the xbl to css is a good one, as
I know often I need to increase sizes on the Mac for things to fit.

That said, I think the icons should go away. If it's a dropdown with a date or a
time in it, that should be more than enough of an indicator as to the         
element's function. Otherwise the UI element isn't as familiar a sight.

Thoughts?

Comment 4

[Stuart Parmenter]

I like the idea of moving this in to CSS, but I don't really care for the icons.

Comment 5

[gekacheka]

I agree that these icons don't look great, they were just an illustration.  It's
ok with me to leave them out.  In particular, the clock icon may be confusing,
as it shows a fixed time, not the time in the field.  

I don't agree that all date formats are instantly recognizable as a date,
particularly if it uses a small year such as 04-12-20.

Comment 6

[Matthew (lilmatt) Willis]

Then I'll edit bug 274916 to not delete datepicker.css so these patches will
work (obviously without the graphics). 

Having a label such as "Starts on" goes a long way to identifying the field as a
date. I agree that four-digit years should be used if we're defining the date
layout, but IIRC what calendar uses is what you have the OS set to.

Comment 7

[Matthew (lilmatt) Willis]

I've made a new patch for bug 274916. At the same time I removed the redundant
.css files in the *stripe themes. If at some point Sunbird needs different
date/timepicker.css files for Mac or Win/Lin, then they can branch.

Once that gets accepted, I (or gekacheka) can make a new patch for this bug as well.

Comment 8

[Matthew (lilmatt) Willis]

Comment on attachment 168972 [details] [diff] [review]
patch datepicker, timepicker to move width to css, add images to modern only

r+ with the following:

We've deleted date/timepicker.css from p/winstripe, as they did not differ from
the xpi classic skin. 

Also, timepicker should be increased to 8em for Mac.

Comment 9

[Matthew (lilmatt) Willis]

Reassigning to gekacheka, ccing mostafah

Comment 10

[Matthew (lilmatt) Willis]

Patch checked in with comments.

-> FIXED

Comment 11

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!