275070 - remove preprocessing, other cleanups

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Mike Shaver (:shaver emeritus)]

Patch coming for quick review

Comment 1

[Mike Shaver (:shaver emeritus)]

Attachment: cleanups, also fixes for 274464

Other than the caldav server not liking me modifying (403, need to check logs),
this seems to work fine.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 168976 [details] [diff] [review]
cleanups, also fixes for 274464

>Index: calAttendee.js

>+var makeMemberAttr;
I take it this is to surpress errors when trying to load this file as
component? Can you comment that? (same for the other files you do this)

>Index: calItemBase.js
>@@ -269,6 +313,9 @@ calItemBase.prototype = {
>+        // Make sure that the LMT and ST are updated
>+        var suppressDCE = this.lastModifiedTime;
>+        suppressDCE = this.stampTime;
I don't see what is going on here. How does this update LMT and ST? It seems to
just read them

Comment 3

[Mike Shaver (:shaver emeritus)]

Attachment: forgot to diff public/ before

Comment 4

[Mike Shaver (:shaver emeritus)]

> >+var makeMemberAttr;
> I take it this is to surpress errors when trying to load this file as
> component? Can you comment that? (same for the other files you do this)

Sure.

> >Index: calItemBase.js
> >@@ -269,6 +313,9 @@ calItemBase.prototype = {
> >+        // Make sure that the LMT and ST are updated
> >+        var suppressDCE = this.lastModifiedTime;
> >+        suppressDCE = this.stampTime;
> I don't see what is going on here. How does this update LMT and ST? It seems to
> just read them

It reads them through the accessors, which trigger the updates.

Comment 5

[Mike Shaver (:shaver emeritus)]

Fixed on trunk.