275080 - User Profile Bugs

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, enhancement)

Description

[alanjstr]

1) There's no Disable button
2) I can't uncheck Editor, even if I uncheck Admin.

Comment 1

[Wolf [:wolf]]

(1) is WFM
(2) is not a change in functionality from Update 0.9. Editor is inheirited by
Admin, therefore you incrementally remove the rights. because it makes no sense
to  be able to disable editor while admin is enablec.

Comment 2

[alanjstr]

I unchecked the admin box.  You're saying I have to save the changes and THEN
remove the editor checkbox?

Comment 3

[Wolf [:wolf]]

Yes :-)

Comment 4

[alanjstr]

Then consider that a future enhancement.  

Comment 5

[Wolf [:wolf]]

I consider it so minor that its not an enhancement to be bothered with. Its not
like you need to elevate and demote users everyday. :-)

Comment 6

[alanjstr]

Well, unchecking Admin and submitting now removes Editor, too.  Of course you
don't find that out until you're returned to the user's profile.  But maybe that
was just for CTho's profile

Comment 7

[alanjstr]

There's no disable button on the specific Edit This User screen.

Comment 8

[Giorgio Maone [:ma1]]

Attachment: improved user detail permission management

Radio button based permission management in edituser and adduser functions.
Hopefully simpler to user and more maintainable to developer. IMHO, same work
should be done for list/bulk-updates interface.

Comment 9

[alanjstr]

I'd like to get rid of the bulk edit in the 2.0 version.  The 1.x version should
lead the way by fiddling with the single user.

Comment 10

[Wolf [:wolf]]

What's the use case for removing bulk-edit? Typically there has to be a valid
reason besides "I'd like to".

Assume for a moment, that permissions continues to grow like the patch attached
shows that it can. bulk-editing would be useful in alot of cases.

As for the admin/editor issue in C#0, Javascript could be added to handle that
case. or, the UI's editor=disabled option could/should be changed.. the
important part is if admin is checked to ignore editor.

Comment 11

[Wolf [:wolf]]

Comment on attachment 170090 [details] [diff] [review]
improved user detail permission management

As its been on cbeard's review list for awhlie, I'll step in here and help out.
:-)

I didn't test this, but looking over the code, it looks much better, and
nothing caught my eye. Its *much* better than the existing code. :-)
It needs QA testing, but as its not for the stable branch (1.0) but rather 1.1,
it should be good to go. :-)

Comment 12

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

landed on branch & trunk