275107 - Some JS Strict warnings (In am-server.js, am-server-advanced.js, am-serverwithnoidentities.js)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041122] (release) (W98SE)

{{
Warning: redeclaration of var account
Source File: chrome://messenger/content/am-server.js
Line: 186, Column: 10
Source Code:
      var account = accountManager.getAccount(serverSettings.deferredToAccount);

Warning: function onOk does not always return a value
Source File: chrome://messenger/content/am-server-advanced.js
Line: 187
Source Code:
}

Warning: assignment to undeclared variable gServer
Source File: chrome://messenger/content/am-serverwithnoidentities.js
Line: 44
}}

Comment 1

[Serge Gautherie (:sgautherie)]

Neil:
At first glance, I'm puzzled by the <am-serverwithnoidentities.js> case...

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <am-server*.js> [Checked in: Comment 10]

Fixes 2 of the 3 warnings,
plus a (double) code optimization.

Comment 3

[[e-mail]]

(In reply to comment #1)
>At first glance, I'm puzzled by the <am-serverwithnoidentities.js> case...
That panel probably doesn't need any JavaScript to operate at all.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) <am-serverwithnoidentities.js> [Checked in: Comment 10]

Fixes the 3rd warning, per Neil's suggestion.

Test:
MailNews > Edit > M & N Account Settings... > Local Folders

Comment 5

[[e-mail]]

Comment on attachment 169134 [details] [diff] [review]
(Bv1) <am-serverwithnoidentities.js>
[Checked in: Comment 10]

We probably want to cvs remove the .js file too.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 168993 [details] [diff] [review]
(Av1) <am-server*.js>
[Checked in: Comment 10]

No super-review from <[e-mail]> since "2004-12-18" :-(

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 169134 [details] [diff] [review]
(Bv1) <am-serverwithnoidentities.js>
[Checked in: Comment 10]

No super-review from <[e-mail]> since "2004-12-19" :-(

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 169134 [details] [diff] [review]
(Bv1) <am-serverwithnoidentities.js>
[Checked in: Comment 10]

sr=dmose

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 168993 [details] [diff] [review]
(Av1) <am-server*.js>
[Checked in: Comment 10]

sr=dmose

Comment 10

[[e-mail]]

Fixes checked in.

Comment 11

[Scott MacGregor]

It looks like these warning fixes caused Bug 308311.

gServer is no longer getting defined for local folders in amUtils.js because it was getting defined in am-serverwithnoidentities.js.