275116 - nsIArray.idl claims that an exception is thrown on out of range index, instead a fatal assertion occurs

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

If you try to call queryElementAt on an out of range index, nsIArray.idl claims
that you'll get NS_ERROR_ILLEGAL_VALUE.  Instead, you get:

poke###!!! ASSERTION: index out of range: '0 <= aIndex && aIndex < Count()',
file ../../../mozilla/xpcom/ds/nsVoidArray.h, line 71
Break: at file ../../../mozilla/xpcom/ds/nsVoidArray.h, line 71

Comment 1

[Boris Zbarsky [:bzbarsky]]

Yeah, this should use SafeObjectAt() (and the right error return too).

Comment 2

[Andreas Lange]

Attachment: SafeObjectAt, changed error

This seems to follow bz's comment.

Comment 3

[Andreas Lange]

Comment on attachment 176990 [details] [diff] [review]
SafeObjectAt, changed error

Six months since review request, trying different reviewer.

Simple correctness patch.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

I don't know that alecf is active anymore. You might try emailing dougt directly, or requesting review from darin fisher (darin at meer dot net)

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 176990 [details] [diff] [review]
SafeObjectAt, changed error

sr=biesi

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsArray.cpp;
/cvsroot/mozilla/xpcom/ds/nsArray.cpp,v  <--  nsArray.cpp
new revision: 1.13; previous revision: 1.12
done