Closed Bug 275139 Opened 20 years ago Closed 20 years ago

[FIXr]Dynamic changes of border-style don't cause reflow

Categories

(Core :: CSS Parsing and Computation, defect, P1)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.8beta1

People

(Reporter: ian, Assigned: bzbarsky)

References

()

Details

Attachments

(1 file)

STEPS TO REPRODUCE 1. Change a "border-style" property from 'none' to 'solid. ACTUAL RESULTS Not much. EXPECTED RESULTS Reflow. TESTCASES http://www.hixie.ch/tests/adhoc/css/border/dynamic/001.html http://www.hixie.ch/tests/adhoc/css/border/dynamic/002.html
Blocks: 258377
Assignee: nobody → dbaron
Component: Layout: Block and Inline → Style System (CSS)
QA Contact: layout.block-and-inline → ian
Attached patch PatchSplinter Review
The first hunk is not strictly needed for this bug, but I had it in my tree anyway (maybe as a fix to some other bug whose patch has been forgotten?)... it seems like a more correct setup for the default values in the struct. The second hunk is what fixes this bug.
Assignee: dbaron → bzbarsky
Status: NEW → ASSIGNED
Attachment #171666 - Flags: superreview?(dbaron)
Attachment #171666 - Flags: review?(dbaron)
Priority: -- → P1
Summary: Dynamic changes of border-style don't cause reflow → [FIX]Dynamic changes of border-style don't cause reflow
Target Milestone: --- → mozilla1.8beta
Comment on attachment 171666 [details] [diff] [review] Patch r+sr=dbaron on the second chunk; please file a separate bug on the first -- I'm not prepared to try to understand all that code right now
Attachment #171666 - Flags: superreview?(dbaron)
Attachment #171666 - Flags: superreview+
Attachment #171666 - Flags: review?(dbaron)
Attachment #171666 - Flags: review+
Summary: [FIX]Dynamic changes of border-style don't cause reflow → [FIXr]Dynamic changes of border-style don't cause reflow
Second hunk checked in. Bug 279156 filed on the first hunk.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: