275159 - Remove duplicate {get|set|remove}AttributeNode* implementation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

At the moment GenericElement and XULElement have almost
exactly the same implementation for DOMElement methods
{get|set|remove}AttributeNode*. We could add a generic implementation
which would be used in both cases.

Patch coming.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Just so you know, the plan is to make nsXULElement inherit nsGenericElement, at
which point we could simply remove the implementation in nsXULElement.

I'm not entierly sure how long until we're able to do that, but I think that
most obstacles are removed so it shouldn't be too hard (it's at the top of my
list once I get some time to work on mozilla again).

So IMHO we could just wait until then since these functions are so small anyway.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

ok. I was just going to ask the question about the plan to make
nsXULElement to inherit nsGeneritElement.
You were faster :)
But any estimates when that might happen?

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I should be able to do it during march

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

This will be fixed in Bug 198533.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

This was fixed in Bug 198533