275288 - Remove CRC calculations from CNavDTD

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Currently, we have #ifdef'd out code in CNavDTD/nsDTDUtils that calculates the
CRC32 value of a given document. I don't think anybody since RickG even knows or
cares about any CRC values for any documents, so I've taken all of the code out.
Patch upcoming shortly.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

This patch may apply with some fuzz (a couple of lines, I hope). It removes the
CRC stuff from the parser.

Note: there is one part where we end up with a construct like:
if (NS_SUCCEEDED(result)) {
  if (NS_OK == result) {
    ...
  }
}

I've left this the way it was because the parser does some funky stuff with
return values (just under that it has nsresult result = 1;). If you want me to
take the ifs out, please tell me.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 169116 [details] [diff] [review]
patch v1

I'm taking the liberty of giving r+ for this trivial patch...

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Checked in.