275342 - Remove unused ui.key.saveLink.shift pref

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[João]

Comment 1

[João]

Key ui.key.saveLink.shift still exists on prefs.js, altough code using it has
been removed. Check related issue 274491.

Comment 2

[Phil Ringnalda (:philor)]

*** Bug 275341 has been marked as a duplicate of this bug. ***

Comment 3

[Phil Ringnalda (:philor)]

*** Bug 275340 has been marked as a duplicate of this bug. ***

Comment 4

[Mike Connor [:mconnor]]

if you have a user-set pref, it gets kept unless you reset it via about:config,
unless we specifically migrate that pref to something new and delete the
original user-set value.  This is by design in order to allow profiles to be
backwards compatible.

Comment 5

[Nickolay_Ponomarev]

See bug 255181. It's not in prefs.js, but in greprefs/all.js (default values).
That makes it show up in about:config - which confuses people who change it but
nothing happens.

See http://lxr.mozilla.org/seamonkey/search?string=ui.key.saveLink.shift

Comment 6

[Mike Connor [:mconnor]]

ooh, that's "fun" since there's no communicator-global version of all.js (like
our firefox.js)

there's a few others like this too.

Comment 7

[Steffen Wilberg]

Seamonkey's equivalent to firefox.js is browser-prefs.js:
http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/browser-prefs.js

This pref could be moved from all.js to browser-prefs.js, since it's only used here:
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigator.js#1392
http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/contentAreaClick.js#240

Thunderbird doesn't use the former, and has a forked version of the latter.

Comment 8

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change

Comment 9

[Javi Rueda :javirid]

Doing a search in MXR, those results were obtained:

http://mxr.mozilla.org/comm-central/source/mozilla/js/src/tests/e4x/Regress/regress-308111.js#827
http://mxr.mozilla.org/comm-central/source/mozilla/modules/libpref/src/init/all.js#1345
http://mxr.mozilla.org/comm-central/source/mozilla/modules/libpref/src/init/all.js#2246
http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js#1573
http://mxr.mozilla.org/comm-central/source/suite/common/contentAreaClick.js#126
http://mxr.mozilla.org/comm-central/source/suite/common/utilityOverlay.js#1311
http://mxr.mozilla.org/comm-central/source/suite/common/utilityOverlay.js#1337

Iy looks that there are some /common/ code that needs the preference value. It is needed to work on this bug?

Comment 10

[Gregory Pappas [:gregp]]

mozilla-central doesn't use this pref, let's move it.

Comment 11

[Gregory Pappas [:gregp]]

Attachment: Bug 275342 - Remove unused ui.key.saveLink.shift pref r?Gijs!

Comment 12

[Gregory Pappas [:gregp]]

Nvm, Seamonkey uses this pref, not thunderbird. Seamonkey is based on a very old copy of m-c afaik so removing this pref shouldn't break anything there.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34eaed21d530
Remove unused ui.key.saveLink.shift pref r=Gijs

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/34eaed21d530