275357 - New Task always defaults to current day instead of selected day

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Eike Stepper]

select a day other than today and add a new task (either toolbar or contextmenu).
the popup dialog will nevertheless show up with current day.
it should be like adding an event, which correctly defaults to the selected day.

Comment 1

[gekacheka]

Attachment: calendar.js, toDoDialog.js patch: used selected datetime for default datetime

(patch -p 2 -i file.patch)

New task defaults to no start date or due date, so cannot just set the dates on
the created task (as is done for new event).

If task has no start or due datetime, task dialog did not change
datetimepickers from their default, the current date time.

Fix is to get the selectedDateTime and pass it to the task dialog as an
additional field on args, so it can default datetimepickers to that time
instead.

Tested as follows (on 0.2 branch):

For each view (day view, week view, multiweek view, month view)
  select a grid box
    toolbar "New Task":  dialog should show selected date time for start & due
    task list context menu "New Task": dialog should show selected date time
  context-click grid box: dialog should show clicked date time for start & due

Comment 2

[Joey Minta]

*** Bug 289229 has been marked as a duplicate of this bug. ***

Comment 3

[Joey Minta]

Attachment: patch v1

Task start and due dates stay disabled, but when enabled, they now have the
currently selected day in their datepickers.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 191594 [details] [diff] [review]
patch v1

r=mvl

Comment 5

[Joey Minta]

patch checked in

Comment 6

[gekacheka]

Comment on attachment 191594 [details] [diff] [review]
patch v1

>+        var selectedDay = window.opener.gCalendarWindow.currentView.getNewEventDate();

This is not a good change.  It makes the event dialog dependent on the opener,
whereas before it was independent of the opener, so in theory the event dialog
could be used by other applications.  A better approach is to pass the date in
as an additional parameter, so any application can use the event dialog.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

That might be a better fix, but the dialog is not meant to be used from other
apps. The dialog is calendar/base does have that purpose, but this one doesn't.
So  I don't see it as a problem.

Comment 8

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!