275365 - Support mozilla/gfx on WinXP AMD64 build.

Status: RESOLVED DUPLICATE of bug 305291

(Core Graveyard :: GFX, enhancement)

Description

[Makoto Kato [:m_kato]]

GDI handle on Win64 is 64bits.  But current code is used as 32bits.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: patch of mozilla/gfx and mozilla/layout

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This approach looks reasonable; someone more familiar than I am with AMD64 stuff
should review the details (i.e., the ifdefs in nsIRenderingContext.h and
nsRenderingContextWin.cpp and the other changes in the latter).

However, I wonder if we really want PRWord (deprecated?) or something like that
rather than creating a new nsGraphicHandle type.

Comment 3

[Makoto Kato [:m_kato]]

David, although OS handle for Graphic isn't defined on current Mozilla code, if
we should use PRWord instend of new type like my proposal fix, I change it.   

And Window for AMD64 code is written by me only, there is no other stuff for Win
for AMD64.

Comment 4

[pete]

nits:

Don't use _MSC_VER to test for LONG_PTR, that tests the compiler version, not if
they've downloaded the latest Platform SDK or not. Doesn't matter anyway (see below)

         if(NS_REINTERPRET_CAST(PRUint32, window->window) != hdc)
^-- shouldn't that cast also be changed to nsGraphicHandle too?

mMozContext->RetrieveCurrentNativeGraphicData((nsGraphicHandle *)(&hdc));
^-- I don't like that because of type aliasing issues among other things, just
create another variable and get rid of the cast

And I know this isn't your original code, but now's a good time as any to change it:
void CALLBACK LineDDAFunc(int x,int y,LONG lData)
^-- make this a static func and change LONG to LPARAM

+    LineDDA((int)(aX0),(int)(aY0),(int)(aX1),(int)(aY1),(LINEDDAPROC)
LineDDAFunc,(LONG_PTR)&dda_struct);
^-- change that last cast to LPARAM instead and get rid of the cast to LINEDDAPROC

Speaking of PRWord/PRUWord. I'd love to see those renamed to PRIntptr and
PRUintptr (to match intptr_t and uintptr_t from C99's stdint.h) and have those
used for these kind of things instead.

Comment 5

[Makoto Kato [:m_kato]]

This was fixed by bug 305291.

*** This bug has been marked as a duplicate of 305291 ***