275378 - Literal RegExp in case block gives syntax error

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Martin Zvieger]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040910
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040910

The JavaScript engine gives a syntax error - the problem is also in Mozilla 1.7.3
Minimal example which demonstrates the behaviour:

// Paste this stuff in some *.js file and load the page

var tmpString= "XYZ";
// works
/ABC/.test(tmpString);
var tmpVal= 1;
if (tmpVal == 1)
{
	// works
	/ABC/.test(tmpString);
}
switch(tmpVal)
{
case 1:
	{
		// works
		/ABC/.test(tmpString);
	}
	break;
}
switch(tmpVal)
{
case 1:
	// fails with syntax error
	/ABC/.test(tmpString);
	break;
}



Reproducible: Always

Comment 1

[Martijn Wargers (dead)]

Attachment: Testcase

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

martijn.martijn, please check " Reassign bug to owner and QA contact of selected
component " when changing the component of bugs.

Comment 3

[Stipe Kotarac]

Confirmed on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6)
Gecko/20041219 Firefox/1.0+ (stipe)

Comment 4

[Brendan Eich [:brendan]]

Attachment: fix

Comment 5

[Brendan Eich [:brendan]]

Old bug, easy fix.

/be

Comment 6

[Brendan Eich [:brendan]]

Not blocker, just put parentheses around the regexp to work around the bug.

/be

Comment 7

[Brendan Eich [:brendan]]

timeless, feel free to nominate for active branches.

/be

Comment 8

[Brendan Eich [:brendan]]

$ cvs ci -m"Twiddle TSF_OPERAND when peeking after switch case label, to scan
regexp literal at start of labeled statement (275378, tachyonal r=shaver)."
jsparse.c
Checking in jsparse.c;
/cvsroot/mozilla/js/src/jsparse.c,v  <--  jsparse.c
new revision: 3.117; previous revision: 3.116
done

Comment 9

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 169243 [details] [diff] [review]
fix

Exactly as I imagined it! r=shaver

Comment 10

[Bob Clary [:bc] (inactive)]

Attachment: js1_5/Regress/regress-275378.js

Martin, with your permission this test case will be added to the javascript
test library.

Comment 11

[Martin Zvieger]

(In reply to comment #10)
> Created an attachment (id=174892) [edit]
> js1_5/Regress/regress-275378.js
> Martin, with your permission this test case will be added to the javascript
> test library.
Go with it...

Comment 12

[Bob Clary [:bc] (inactive)]

js1_5/Regress/regress-275378.js checked in.

Comment 13

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.x and trunk.