275416 - Safari cannot recognise CSS classes that have newlines in them

Status: RESOLVED DUPLICATE of bug 274400

(Bugzilla :: Bugzilla-General, defect)

Description

[Nicolas Simonds]

The file table.html.tmpl uses the following code to generate the pretty colours in the buglist:
----
 <tr class="bz_[% bug.bug_severity FILTER css_class_quote %]
            bz_[% bug.priority FILTER css_class_quote %]
            bz_[% bug.bug_status FILTER css_class_quote %]
            bz_[% bug.resolution FILTER css_class_quote %]
            [%+ "bz_secure" IF bug.isingroups %]">
----

...very clean, and works well enough, but on Mac OS X, Safari does not display any styles on the bugs at 
all.  I tracked this down to Safari being disgruntled about newlines in the classnames, changing it to the 
(much, much) uglier:

----
 <tr class="bz_[% bug.bug_severity FILTER css_class_quote %] bz_[% bug.priority FILTER css_class_quote 
%] bz_[% bug.bug_status FILTER css_class_quote %] bz_[% bug.resolution FILTER css_class_quote %] [%+ 
"bz_secure" IF bug.isingroups %]">
 ----

...works as expected.  This is confirmed as existing in 2.17.7 and HEAD.  Probably elsewhere, too, but I 
didn't look.  ;)

Comment 1

[Shane H. W. Travis]

If bug 274440 was a 2.18 blocker, this one probably should be too.

Nick's fix on that bug can probably be applied here just about as easily.

Comment 2

[Nicolas Simonds]

Attachment: table.html.tmpl.patch

This turns what was beautiful and broken into something hideous and functional.

Comment 3

[Shane H. W. Travis]

Comment on attachment 169225 [details] [diff] [review]
table.html.tmpl.patch

Nicolas; see nick barnes' patch on bug 274440 to see how to make it "beautiful
and functional"  -- at least as far as the TT code goes. They both look the
same in the resultant HTML, but there's no need to make the programmers' eyes
bleed. :)

Comment 4

[Shane H. W. Travis]

(In reply to comment #3)
> Nicolas; see nick barnes' patch on bug 274440...

That should read bug 274400 -- oops. Sorry.

Comment 5

[Nicolas Simonds]

Attachment: table.html.tmpl.patch (remix)

Touche.  Here is a version that works in Safari and does not cause undue pain
and suffering...

Comment 6

[Shane H. W. Travis]

Comment on attachment 169227 [details] [diff] [review]
table.html.tmpl.patch (remix)

+	      [%+ "bz_secure" IF bug.isingroups -%]">

The "-" on this last line is unnecessary, because there is no line break
between %] and ">

This *probably* wouldn't have any additional negative effect, but it's
extraneous and unneeded... so no point taking any chances.

Fix that trivial issue for an r+ from me.

Comment 7

[Nicolas Simonds]

Attachment: table.html.tmpl.patch (third time's the charm)

Version of the patch with no extra "-" signs in it.  ;)

Comment 8

[Shane H. W. Travis]

Nicolas, I owe you an apology. On cursory examination, I thought that bug 
274400 was different from this bug, but it's not; they both target *exactly the 
same code*. 

Your third patch didn't apply to 2.18rc3; when I looked to see why, it's 
because the changes had already been made by someone else! Using 
http://bonsai.mozilla.org/cvsguess.cgi?file=table.html.tmpl to pull up the 
file, I found that they had been checked in as part of bug 277440.

At least you know that this fix *has* made it in to 2.18 ... but I apologize 
for the extra, unnecessary work on your part.


*** This bug has been marked as a duplicate of 274400 ***

Comment 9

[Dave Miller [:justdave]]

clearing target of DUPLICATE/WONTFIX/INVALID/WORKSFORME so they'll show up as
untriaged if they get reopened.