275463 - embedding/browser/gtk should not use deprecated nsIPref

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect, P2)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

there's an unused sPrefs member; it can be easily removed.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Marco Pesenti Gritti]

Comment on attachment 169250 [details] [diff] [review]
patch

Looks like you can remove REQUIRES=pref from the Makefile too?

The patch looks good. Though I dont know why sPrefs was there in first place, I
cant remember gtkmozembed using any pref in the past.

I wonder if maybe it was there to ensure the service was initialized... I
tested both TestGtkEmbed and epiphany with the patch though, without noticing
any initialization problems. So this looks safe to check in to. May be a good
idea to pick Blizzard as super reviewer though... he may remember.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

yep, looks like I can remove prefs from REQUIRES.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 169306 [details] [diff] [review]
patch v2

carrying forward marco's r+

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in src/EmbedPrivate.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrivate.cpp,v  <--  EmbedPrivate.cpp
new revision: 1.55; previous revision: 1.54
done
Checking in src/EmbedPrivate.h;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrivate.h,v  <-- 
EmbedPrivate.hnew revision: 1.27; previous revision: 1.26
done
Checking in src/Makefile.in;
/cvsroot/mozilla/embedding/browser/gtk/src/Makefile.in,v  <--  Makefile.in
new revision: 1.56; previous revision: 1.55
done