275527 - Cannot import certificate backup

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Wolfgang Preuss]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041207
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041220

After a succesfull certificate backup the corresponding import is not possible
with the latest Mozilla builds, as in the certificate managers password entry
dialog the OK button is not highlighted. 


Reproducible: Always

Steps to Reproduce:
1. Preferences - Privacy & Security - Certificates - Manage Certificates 
    - Your Certificates - Backup All 
      - Enter Master Password for the Software Security Device
        - Choose a Certificate Backup Password (twice)  
   --> Certificates backup o.k.
2. At the point above remove the actual certificate from the Software Security     
   Device by using the delete button 
3. At the point above try to import the previously exported certificates 
    ...
        - Password Entry Dialog
          (please enter the password that was used to encrypt this certificate
           backup) 
    --> (Enter the password and try to hit the o.k. button) --> not possible

Actual Results:  
Certificates are no more available, signing of mails impossible. 

Expected Results:  
Import of the certificates backup should be possible

Until Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041207
this problem did not exist.
Reason for my test: 
In the Microsoft implementation of the certificate backup/restore there is a
possibility to make a restore that forbids any subsequent backup and I wanted to
know if such an option is available in the Mozilla version too.
From my point of view as normal user such an option might improve the security
of certificates.

Comment 1

[Stefan Borggraefe]

Thanks for the good bug report. :-)

This regression is caused by my patch for bug 251991. Fix upcoming...

Comment 2

[Stefan Borggraefe]

Attachment: Patch

Comment 3

[[e-mail]]

Comment on attachment 169316 [details] [diff] [review]
Patch

Looks reasonable.

Comment 4

[Stefan Borggraefe]

Comment on attachment 169316 [details] [diff] [review]
Patch

Moving sr-request to jag.

Comment 5

[Asa Dotzler [:asa]]

Jag, you around? Can you have a look at this?

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 169316 [details] [diff] [review]
Patch

sr=jst

Comment 7

[Stefan Borggraefe]

Comment on attachment 169316 [details] [diff] [review]
Patch

Asking for approval. Simple regression fix, low risk.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 169316 [details] [diff] [review]
Patch

a=asa for 1.8a6 checkin.

Comment 9

[Stefan Borggraefe]

Fix checked in.

Comment 10

[Wolfgang Preuss]

Thank you very much, problem is fixed and certificate backups can be imported now
as expected.

Since 1.8b I have a problem with S/MIME signed mails, see bug 279346.

Comment 11

[Stefan Borggraefe]

(In reply to comment #10)
> Thank you very much, problem is fixed and certificate backups can be imported now
> as expected.

Ok, marking VERIFIED then.