275532 - Don't expose STATE_SELECTED for text objects

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

The STATE_SELECTED state is intended to be used with selected choices in
widgets, such as list or tree items.

Right now we calculate whether the selection is currently in a text object for
each text object in the tree, which only slows us down.

Comment 1

[Aaron Leventhal]

Attachment: Remove STATE_SELECTABLE/STATE_SELECTED calculation from nsHTMLTextAccessible::GetState()

Comment 2

[Louie Zhao]

Comment on attachment 169286 [details] [diff] [review]
Remove STATE_SELECTABLE/STATE_SELECTED calculation from nsHTMLTextAccessible::GetState()

This patch is ok. From the definition and real experience working with AT-Tools
on Unix, STATE_SELECTED/SELECTABLE is not needed for Text object.

One minor thing: 


>@@ -80,32 +80,10 @@ NS_IMETHODIMP nsHTMLTextAccessible::GetS
>   nsCOMPtr<nsIPresShell> shell(GetPresShell());
>   if (!shell) {
>      return NS_ERROR_FAILURE;  
>   }

These 3 lines can also be deleted since it's useless.

Comment 3

[Aaron Leventhal]

Thanks Louie.

Comment 4

[Henry Jia]

Comment on attachment 169286 [details] [diff] [review]
Remove STATE_SELECTABLE/STATE_SELECTED calculation from nsHTMLTextAccessible::GetState()

sr=Henry

Comment 5

[Aaron Leventhal]

Checking in nsHTMLTextAccessible.cpp;
/cvsroot/mozilla/accessible/src/html/nsHTMLTextAccessible.cpp,v  <-- 
nsHTMLTextAccessible.cpp
new revision: 1.39; previous revision: 1.38
done