Closed Bug 275558 Opened 20 years ago Closed 20 years ago

Filter based on custom header doesn't work automatically after upgrade to Moz 1.7.5

Categories

(MailNews Core :: Filters, defect)

Product:
MailNews Core
Component:
Filters
Version:
1.7 Branch
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: cstef, Assigned: Bienvenu)

References

Details

(Keywords: fixed1.7.6)

Attachments

(2 files)

Requested prefs.js
23.60 KB, application/octet-stream
Details
proposed fix
724 bytes, patch
mscott
: superreview+
mkaply
: approval1.7.6+
Details | Diff | Splinter Review 
After I upgraded to Mozilla 1.7.5, some of my message filters stopped working.
As far as I could find out, they use List-Id custom header (I found two filters
based on that header now working, and one based on Sender that works).
If new message arrives into my Inbox, it is not moved to appropriate folder and
filter log remains empty. But if I select "Run filter on folder" from "Tools"
menu, message is moved to folder where it has to be moved, and log item appears
in filter log.
"List-Id" header causes problem of Bug 124641 many time, filter/seacrh problem
when multiple-line header, because it tends to be multiple line header.
> Bug 124641 : Filter or Search: do not handle multi-line (wrapped, folded)
headers correctly.

And Bug 275190 reports similar filtering problem after migration to Mozilla 1.7.5
and only when automatic mail filtering for incoming mail.
Bug 275190 says problem occurs on filter for "Mailing-List:" header, and it also
tends to be multiple line header. 

But if your problem and Bug 275588 is multiple line header problem,
I cannot imagine reasons why the problem occurs only when 1.7.5 and "automatic
filtering for incoming mail"...
Why problem did not occur before 1.7.5?
Why problem does not occur when "Run Filter on folder"?
If I save message in a file, List-Id header in that file look one-line. It is
--------------------------------------------------------------
List-Id: =?koi8-r?b?VU7pWCDTxc3JzsHS?= <uneex.imap.cs.msu.su>
--------------------------------------------------------------
On Mozilla 1.7.3 everything worked fine, but now automatic filtering does not
work (for List-Id filter rules, other custom headers seem to work), running
filters by hand works. I tried to remove List-Id header from list of custom
headers and to add it again (and fixing filter rules after it), but nothing changed.
(In reply to comment #2)
> List-Id: =?koi8-r?b?VU7pWCDTxc3JzsHS?= <uneex.imap.cs.msu.su>

Does you filter condition is for ascii part(uneex.imap.cs.msu.su)?
Or mail-addr included in encoded part(decoded =?koi8-r?b?VU7pWCDTxc3JzsHS?=)?
My filter condition is 'List-Id contains uneex.imap.cs.msu.su'.

I have also encountered this problem.  I have a series of cascading
"X-Spam-Level contains *****" filters to sort possible spam marked by
SpamAssassin into a set of folders of increasing spamynisity.  These filters
worked fine in Mozilla Suite 1.7.x prior to my recent upgrade to 1.7.5.

Now, the filters do not activate automatically upon fetching new mail. Other
filters refering only to non-custom headers work fine. Executing Run Filter(s)
on Folder inbox does play these custom header filters correctly.

Thinking it might have been a problem with filter specification inherited from a
previous version, I deleted the customer headers and their filters, then
recreated them in 1.7.5.  This did not correct anything.

My headers are one-line and plain ASCII.

(In reply to comment #4)
> My filter condition is 'List-Id contains uneex.imap.cs.msu.su'.
> 
are these imap or pop3 accounts? Can you attach or e-mail me your prefs.js along
with the filter in question? It might be the cae that we're not downloading the
required header for some reason...
Attached file Requested prefs.js — 
(In reply to comment #6)
> are these imap or pop3 accounts?

POP3

> Can you attach or e-mail me your prefs.js along
> with the filter in question?

OK.  BTW, what file are the filter definitions stored in? Would it help to
attach that too?
for pop3, in the server sub-directory of your user profile dir, in
msgFilterRules.dat - but if this is broken for pop3 as well, then I don't think
I need to see your prefs.js (that only affects imap in this case)

has anyone tried trunk builds of Mozilla to see if they have the same problem there?
(In reply to comment #8)
> has anyone tried trunk builds of Mozilla to see if they have the same problem
there?

David, reporter of Bug 275190 says that problem is 1.7.5 only, no problem on any
of 1.7.3 / 1.8a5 / latest trunk nightly(just before 1.8a6 release).
See Bug 275190 comment #14 and Bug 275190 comment #15.

There are three same reports on the problem.
The only defference among them is used "cutomized" header in filter.
 - Bug 275190            : "Mailing-List:" & "contains"
 - Bug 275558 comment #0 : "List-Id:" & "contains"
 - Bug 275558 comment #5 : "X-Spam-Level" & "contains"
This bug can be closed as DUP of Bug 275190.
I (the reporter of this bug) have IMAP account and the same problem. Should I
attach message on which filter does not work automatically?
I am using mail fiters to filter messages from various mailing lists using
Reply-To header. This stopped working when I upgraded from 1.7.3 to 1.7.5. When
I run them manually most did work and messages were filled into proper folders,
but one of them didn't work even this way, I observed that in this case searched
string was on second line of header. When I tried to use some other string from
header from first line which unfortunately was MIME encoded it didn't work
either. When I completely deleted file with filter definitions and recreated
rules from scratch it didn't help. After gone back to 1.7.3 things started to
work as before.
Same issue here, using an IMAP4 over SSL mail account.

Filters on custom headers "Sender:", "List-Id:"...
stopped working immediately upon upgrade from 1.7.3 to 1.7.5.
Component: MailNews: Main Mail Window → MailNews: Filters
Product: Mozilla Application Suite → Core
I can confirm this behaviour.

The upgrade 1.7.2 -> 1.7.5 broke some of my mail-filters. All filters were
working fine with 1.7.2.

Filters based on Mozilla predefined headers (To, CC) still seem to work.

Filters based on custom headers don't work anymore.

Running the filters manually on my Inbox works.

System: Mozilla 1.7.5 on Linux (SuSE 9.1)

I'll figure out what regressed this.
Assignee: sspitzer → bienvenu
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch proposed fix — — Splinter Review 
porting bug 197166 to 1.7 branch broke this...
Attachment #170577 - Flags: superreview?(mscott)
Attachment #170577 - Flags: approval1.7.6?
Attachment #170577 - Flags: superreview?(mscott) → superreview+
Comment on attachment 170577 [details] [diff] [review]
proposed fix

Did this regression happen on the trunk as well?
Attachment #170577 - Flags: approval1.7.6? → approval1.7.6+
Looking at the log, yes it did happen on the trunk - bug 241499. The trunk has
the correct code now. My bad for not noting and/or realizing that it was the
patch in  bug 197166 that caused this.
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed1.7.6
Resolution: --- → FIXED
*** Bug 275190 has been marked as a duplicate of this bug. ***
*** Bug 277681 has been marked as a duplicate of this bug. ***
(In reply to comment #19)
> *** Bug 275190 has been marked as a duplicate of this bug. ***
David, how about Bug 276056 and Bug 276944 which I saved in "blocks:" of Bug 275190?



Also seeing this with version 0.6+ (20050103)

It doesn't affect ALL filters, however.
Also seeing this with Thunderbird version 0.6+ (20050103)

It doesn't affect ALL filters, however.

(If this is a repeat, I apologize. I hit stop button before it sent, but
sometimes that doesn't always work.)
Bug still occurs in 1.8a6. I use a custom header of Precedence contains list and
Precedence contains bulk, to move to another folder. They don't run
automatically, but do work when I manually run filters.
Well I've install 1.8a6 (build 20050111) and it fixed the issue I had for not
automatically filtering on customised header rules
Is it only me or would others like to know how and when this bug fix is going to
be implemented?  Above says "RESOLVED/FIXED/proposed fix patch"; is somebody
actively working on a patch and will tell the world when it is available?
It says "fixed1.7.6" under "Keywords", doesn't it?
the fix is checked in. It's up to the folks that decide when the next 1.7.x
release comes out as to when there will be a 1.7.x build with the fix. All I can
do is check in the fix and set the 1.7.6 keyword...
*** Bug 276944 has been marked as a duplicate of this bug. ***
(In reply to comment #26)
> Is it only me or would others like to know how and when this bug fix is going to
> be implemented? [...] and will tell the world when it is available?

It is available, upgrade to the latest 1.7 build (pre 1.7.6) from
http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/latest-1.7/.

*** Bug 279863 has been marked as a duplicate of this bug. ***
In case it helps, I installed the latest nightly yesterday and my custom header
filters are working.
*** Bug 280705 has been marked as a duplicate of this bug. ***
*** Bug 280868 has been marked as a duplicate of this bug. ***
*** Bug 281848 has been marked as a duplicate of this bug. ***
*** Bug 282024 has been marked as a duplicate of this bug. ***
*** Bug 282024 has been marked as a duplicate of this bug. ***
*** Bug 282679 has been marked as a duplicate of this bug. ***
*** Bug 288067 has been marked as a duplicate of this bug. ***
This bug is eliminated as of the 1.7.6 gold version of Mozilla Suite.
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: