275613 - pressing [enter] in a textarea in editflagtypes.cgi results in an addition to the inclusion list instead of saving changes

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[timeless]

useragent: safari

steps:
1. load edit: ... flags
2. click some flag to edit
3. change some single line text thing
4. press enter, since you're done and want to save it.

expect:
flag changes are saved

actual results (safari only):
you get the page for creating a new flag based on an old flag.

Comment 1

[Frédéric Buclin]

(In reply to comment #0)
> actual results (safari only):
> you get the page for creating a new flag based on an old flag.

Actually, it doesn't create a new flag, it only adds a new entry in the inclusion list. If you click "Save Changes" after that, the flag type you were editing is updated. The reason is probably that the "Include" button is the first one in the form and so is the one which gets called when pressing "Enter".

There is probably a way to define the default button when pressing enter.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[Frédéric Buclin]

Requesting approval for 2.22 too. The reason is that the current behavior is confusing enough to worth being fixed on this branch.

Comment 4

[Frédéric Buclin]

tip:

Checking in template/en/default/admin/flag-type/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.20; previous revision: 1.19
done

2.22:

Checking in template/en/default/admin/flag-type/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.14.2.1; previous revision: 1.14
done