275621 - blur is fired on element that has been removed from the document

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Mats Palmgren (inactive)]

blur is fired on element that has been removed from the document.

STEPS TO REPRODUCE:
1. load attached testcase
2. TAB once to put focus on the button
3. hover the button - this will remove it
4. click on a different window

ACTUAL RESULTS:
blur() was executed for the button

EXPECTED RESULTS:
nothing

BUILDS & PLATFORMS TESTED:
Bug occurs in Mozilla 2004-12-19-05 trunk Linux.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase

Comment 2

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Comment 3

[Mats Palmgren (inactive)]

The NS_ENSURE_ARG_POINTER isn't really necessary to fix this bug - it just
seemed like the right thing to have there.

Comment 4

[Boris Zbarsky [:bzbarsky]]

What if the node that's removed is an ancestor of the focused node?  This doesn't look 
like it would handle that case...

As for the NS_ENSURE_ARG_POINTER, it should not be needed; the pointer there 
should not be null unless someone is badly abusing the nsIDocument/
nsIDocumentObserver apis.

Comment 5

[Mats Palmgren (inactive)]

(In reply to comment #4)
> What if the node that's removed is an ancestor of the focused node? 

I though nsEventStateManager::ContentRemoved was called for every node...
But it isn't.

> As for the NS_ENSURE_ARG_POINTER, it should not be needed;

oki, I'll remove that then..

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 169329 [details] [diff] [review]
Patch rev. 1

bug 263545 will fix this

Comment 7

[Boris Zbarsky [:bzbarsky]]

Yeah, ContentRemoved() is called on the root of the subtree that was removed.

Comment 8

[Mats Palmgren (inactive)]

The testcase fails in a 20090609 build (before new focus manager landing)
The testcase works in a 20090611 build (after new focus manager landing)
I think this was fixed by the new focus manager (bug 178324).

-> FIXED

Comment 9

[Boris Zbarsky [:bzbarsky]]

Need a regression test.