275634 - Tooltip is absent in print preview window.

Status: RESOLVED WORKSFORME

(Core :: Print Preview, defect)

Description

[Leon Sha]

1.Open mozilla.
2.Load a web page and select 'File->Print Preview'

Observation: Tooltip is absent in the page preview window for the buttons '>|',
'>', '<', '|<' and 'Close'.

Note:This is true for Address Book and Mail also.

Comment 1

[Ganesh]

Verified on Firefox 1.0. I would take a look

Comment 2

[Ganesh]

Attachment: patch attached for review

Comment 3

[Leon Sha]

(In reply to comment #2)
> Created an attachment (id=171468) [edit]
> patch attached for review
> 

This is only for firefox.
How about mozilla?

Comment 4

[Ganesh]

I would get it soon.

Comment 5

[[e-mail]]

Comment on attachment 171468 [details] [diff] [review]
patch attached for review

To whomever writes a Suite version of this patch:

>+<!ENTITY print.tooltip        "Print File">
>+<!ENTITY pageSetup.tooltip    "Review of Pages">
>+<!ENTITY close.tooltip        "Close Preview Window">
I don't know what the FireFox developers will want but for the Suite I would
have thought that labelled toolbarbuttons don't need tooltips.

>+<!ENTITY home-arrow.tooltip   "First Page">
>+<!ENTITY left-arrow.tooltip   "Prevoius Page">
>+<!ENTITY right-arrow.tooltip  "Next Page">
>+<!ENTITY end-arrow.tooltip    "Last Page">
We normally use interCaps style (homeArrow.tooltip etc.) for entity names. Also
you've got a typo: "Prevoius" should be "Previous" ;-)

>-      <xul:toolbarbutton class="home-arrow"
>+      <xul:toolbarbutton class="home-arrow" tooltiptext="&home-arrow.tooltip;"
>         oncommand="parentNode.navigate(0, 0, 'home');"/>
The suite version has two class names in the class attribute. This means that
you'll need to put the tooltiptext attribute on its own line to prevent the
line from getting too long.

Comment 6

[Ganesh]

Attachment: corrected patch for firefox.

I would attach the suite version of patch soon..

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

Ganesh, what's the status here?

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to comment #7)
> Ganesh, what's the status here?

it would seem Ganesh is no longer at Novel (mail bounces).
bug needs a new champion.

Is this a seamonkey-only bug?  It doesn't work on SM trunk (windows) but does work in FF nightly.

Comment 9

[Leon Sha]

I can not see this bug on firefox now. So resolve this bug.