Closed
Bug 275673
Opened 20 years ago
Closed 20 years ago
embedding/browser/cocoa should not use nsIPref
Categories
(Core Graveyard :: Embedding: APIs, defect)
Core Graveyard
Embedding: APIs
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8alpha6
People
(Reporter: Biesinger, Assigned: Biesinger)
References
Details
Attachments
(1 file)
2.41 KB,
patch
|
mikepinkerton
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•20 years ago
|
||
do I need sr for changes in this directory?
Attachment #169366 -
Flags: review?(pinkerton)
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → mozilla1.8alpha6
Comment 2•20 years ago
|
||
should this also be done to the same files in camino?
Assignee | ||
Comment 3•20 years ago
|
||
actually http://lxr.mozilla.org/mozilla/source/camino/src/download/ProgressDlgController.mm does not seem to use nsIPref
Comment 4•20 years ago
|
||
ok, then go ahead with these changes. they've mostly bitrotted, but it can't hurt anything r=pink.
Comment 5•20 years ago
|
||
Comment on attachment 169366 [details] [diff] [review] patch assume sr as well.
Attachment #169366 -
Flags: superreview+
Attachment #169366 -
Flags: review?(pinkerton)
Attachment #169366 -
Flags: review+
Assignee | ||
Comment 6•20 years ago
|
||
thanks, checked in Checking in embedding/browser/cocoa/src/ProgressDlgController.mm; /cvsroot/mozilla/embedding/browser/cocoa/src/ProgressDlgController.mm,v <-- ProgressDlgController.mm new revision: 1.4; previous revision: 1.3 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•