275674 - Build break in mozilla/configure.in

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Rupesh]

The build is failed in "configure" with the below error.

***************************************************************************

checking for X... (cached) no
checking whether ld has archive extraction flags... (cached) no
checking for 64-bit OS... no
I:/builds/moz175/mozilla/configure: 7233: Syntax error: "!" unexpected
*** Fix above errors and then restart with "make.exe -f client.mk build"
make: *** [I:/builds/moz175/mozilla/objret/Makefile] Error 1

*****************************************************************************

Comment 1

[Rupesh]

The similar error occurs with mozilla/configure.in file also. The below patch
may work.

*************************Start***********************************
Index: configure.in
===================================================================
RCS file: /cvsroot/mozilla/configure.in,v
retrieving revision 1.1399
diff -u -8 -r1.1399 configure.in
--- configure.in	15 Dec 2004 05:52:34 -0000	1.1399
+++ configure.in	22 Dec 2004 13:41:54 -0000
@@ -1950,17 +1950,17 @@
                      [cat > conftest.c <<EOF
 #pragma GCC visibility push(hidden)
                       int foo_hidden = 1;
 #pragma GCC visibility push(default)
                       int foo_default = 1;
 EOF
                       ac_cv_visibility_pragma=no
                       if ${CC-cc} -Werror -S conftest.c -o conftest.s
>/dev/null 2>&1; then
-                        if grep '\.hidden.*foo_hidden' conftest.s >/dev/null &&
! grep '\.hidden.*foo_default' conftest.s > /dev/null ; then
+                        if grep '\.hidden.*foo_hidden' conftest.s >/dev/null &&
!grep '\.hidden.*foo_default' conftest.s > /dev/null ; then
                           ac_cv_visibility_pragma=yes
                         fi
                       fi
                       rm -f conftest.[cs]
                     ])
       if test $ac_cv_visibility_pragma = yes; then
         AC_DEFINE(HAVE_VISIBILITY_PRAGMA)
         VISIBILITY_FLAGS='-I$(DIST)/include/system_wrappers -include
$(topsrcdir)/config/gcc_hidden.h'

Index: configure.in
===================================================================
RCS file: /cvsroot/mozilla/nsprpub/configure.in,v
retrieving revision 1.83.2.95
diff -u -8 -r1.83.2.95 configure.in
--- configure.in	15 Dec 2004 05:52:39 -0000	1.83.2.95
+++ configure.in	22 Dec 2004 13:40:26 -0000
@@ -511,17 +511,17 @@
                      [cat > conftest.c <<EOF
 #pragma GCC visibility push(hidden)
                       int foo_hidden = 1;
 #pragma GCC visibility push(default)
                       int foo_default = 1;
 EOF
                       ac_cv_visibility_pragma=no
                       if ${CC-cc} -Werror -S conftest.c -o conftest.s
>/dev/null 2>&1; then
-                        if grep '\.hidden.*foo_hidden' conftest.s >/dev/null &&
! grep '\.hidden.*foo_default' conftest.s > /dev/null ; then
+                        if grep '\.hidden.*foo_hidden' conftest.s >/dev/null &&
!grep '\.hidden.*foo_default' conftest.s > /dev/null ; then
                           ac_cv_visibility_pragma=yes
                         fi
                       fi
                       rm -f conftest.[cs]
                     ])
      if test $ac_cv_visibility_pragma = yes; then
        AC_DEFINE(HAVE_VISIBILITY_PRAGMA)
        VISIBILITY_FLAGS='-I$(dist_includedir)/system_wrappers -include
$(topsrcdir)/config/gcc_hidden.h'
************************************End*************************************

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

No, the space is required.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

fixed by splitting into two ifs.

Comment 4

[Peter Weilbacher]

Not yet. You need to make the same change in nsprpub/configure.in.