275752 - Make checksetup.pl chdir to the bugzilla directory

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[:glob ✱]

checksetup.pl fails if the current working directory isn't bugzilla.

this is expected, however the error message is the standard perl library error:

  Can't locate Bugzilla/Constants.pm in @INC

it'd be easy, and nice, to get checksetup.pl to check the cwd and throw a
different error, such as

  You must run checksetup.pl from the Bugzilla directory

Comment 1

[:glob ✱]

Attachment: v1

Comment 2

[Frédéric Buclin]

or even better, make checksetup.pl to change the cwd to bugzilla.

Comment 3

[:glob ✱]

Attachment: v2

this does a cwd instead of throwing an error.

as the cwd uses File::Basename, we have to ensure the perl version is checked
before we can use it (File::Basename is part of the 5.6 core).

Comment 4

[GavinS]

I think that the check and die from the first patch could still be done - in
case someone has been mad enough to move checksetup.pl.

Also, should we indicate that we have done the change directory?

Comment 5

[:glob ✱]

> I think that the check and die from the first patch could still be done - in
> case someone has been mad enough to move checksetup.pl.

if someone moves checksetup.pl, they are asking for trouble.  what if they move
Bugzilla/Constants, or any other file?  i think we're best off assuming that the
files will be in the correct location.

> Also, should we indicate that we have done the change directory?

personally i don't think so.  things "should just work", the user doesn't need
to know every detail that happened in order to acheive this.

Comment 6

[Marc Schumann [:Wurblzap]]

Comment on attachment 169439 [details] [diff] [review]
v2

This looks good to me.

I have a couple of questions.
Is there a reason to have the chdir part inside the BEGIN block?
Does it make sense to keep require 5.006 inside the BEGIN block, right after
the Win32 5.8.1 check?
And why did you replace the unless/die-combinations by require-statements?
I'm fine with these changes, in fact I like the require variant better, I'm
just curious...

Live and learn: when testing, I was surprised to see that chdir() switches
drives on Win32. Didn't know that. Good thing, makes the patch work.

Comment 7

[:glob ✱]

Attachment: v3

> Is there a reason to have the chdir part inside the BEGIN block?

yes, "uses" is compile time, so the chdir needs to happen at compile time also.
 

> Does it make sense to keep require 5.006 inside the BEGIN block, right after
> the Win32 5.8.1 check?

yes, that's logical.  don't know what i was thinking before.  here's an update.

carrying forward r+

> And why did you replace the unless/die-combinations by require-statements?
> I'm fine with these changes, in fact I like the require variant better, I'm
> just curious...

a few reasons:

  1.  it's the standard perl way of checking for the version
  2.  it's less, cleaner code
  3.  the error message includes the current perl version

Comment 8

[Dave Miller [:justdave]]

I hate to be messing with this kind of stuff in checksetup.pl during a freeze,
but this is a frequent support issue lately, so better to nip it sooner than
later...

Comment 9

[Vlad Dascalu]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.328; previous revision: 1.327
done