275809 - Bonsai won't display files that have a plus character in the name

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Bonsai, defect)

Description

[dleh]

Bonsai's cvsview2.cgi script doesn't handle directories (and possibly files)
that contain '+' in the name. For example, when clicking on a link for a file
"dir1/dir+with+plus/file1.cpp" from the likes of a cvsquery.cgi results page I
get a 'Software Error: Directory dir1/dir with plus/file1.cpp not found' - i.e.
the '+' characters have been turned into spaces.

Comment 1

[cls]

One of the problems is that the files are being double decoded.  $opt_files is
set from $request->param() which apparently decodes the file.  Later, when
splitting individual files from $opt_files, we explicitly call &url_decode from
CGI.pl.  I remember adding the url_decode call because I was hitting a situation
where the contents of $opt_files were not being decoded.  perl has been upgraded
on my server since then so I'm not able to reproduce that setup.  If we can
expect $request->param() to decode the args, then we can remove those explicit
url_decode calls.   We also would have to make explicit the assumption that + in
urls means space and that if you want to pass an actual +, then you'll have to
encode it (as %2B).

Comment 2

[timeless]

http://landfill.mozilla.org/bonsai-test/bonsai/rview.cgi?branch=&command=DIRECTORY&dir=plague/newdir/ark%2b&files=ansas&root=/home/cvsroot&subdir=plague/newdir/ark%20

fwiw is the test version (still doesn't work). not sure how many steps we are away from making it work.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

timeless, any chance of fixing this?

mxr-test's bonsai is actually more broken than bonsai.m.o, since CVS log works on bonsai.m.o (only blame is broken), but both blame *and* log are broken on mxr-test.  (If bug 570737 goes through, this means things are a double-regression for all of these files, both from the otherwise annoying Hg blame which works, and also from Hg log for Hg/CVS log for CVS.)

E.g., http://mxr-test.konigsberg.mozilla.org/camino/source/camino/src/extensions/NSString+Utils.m

Comment 5

[timeless]

smokey: so... there are a couple of bugs floating around here. This bug is filed against bonsai. But.

http://mxr-test.konigsberg.mozilla.org/camino/source/camino/src/extensions/NSString+Utils.m
https://hg.mozilla.org/camino/log/8bc0877e8c6c/src/extensions/NSString%2BUtils.m
http://mxr-test.konigsberg.mozilla.org/bonsai/cvslog.cgi?file=/camino/src/extensions/NSString%2BUtils.m&mark=8bc0877e8c6c&tree=camino

all work with a fix to mxr (not bonsai) - bug 572497.

I'm currently mostly working on bonsai (as you noted), but I'll push a fix for this on the MXR side.

Comment 6

[Adam Muntner [:adamm] (use NEEDINFO)]

Bonsai was decommissioned, closing all remaining bugs "wontfix"